Bug 450836

Summary: Ignoring return value in gfs_mkfs
Product: [Fedora] Fedora Reporter: Steve Whitehouse <swhiteho>
Component: GFSAssignee: Robert Peterson <rpeterso>
Status: CLOSED UPSTREAM QA Contact:
Severity: low Docs Contact:
Priority: low    
Version: rawhideCC: fdinitto
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-06-19 05:22:56 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Proposed patch none

Description Steve Whitehouse 2008-06-11 09:42:49 UTC 
From the is64 build logs:

gcc -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -Wall -Wformat=2 -MMD -O2 -g
-I/usr/src/upstream/cluster/rhcluster/cluster/make
-DDEFAULT_CONFIG_DIR=\"/etc/cluster\" -DDEFAULT_CONFIG_FILE=\"cluster.conf\"
-DLOGDIR=\"/var/log/cluster\" -DSYSLOGFACILITY=LOG_LOCAL4
-DRELEASE_VERSION=\"2.99.03\" -Wall -Wformat=2 -MMD -O2 -g
-I/usr/src/upstream/cluster/rhcluster/cluster/make
-DDEFAULT_CONFIG_DIR=\"/etc/cluster\" -DDEFAULT_CONFIG_FILE=\"cluster.conf\"
-DLOGDIR=\"/var/log/cluster\" -DSYSLOGFACILITY=LOG_LOCAL4
-DRELEASE_VERSION=\"2.99.03\" -Wall -Wformat=2 -MMD -O2 -g
-I/usr/src/upstream/cluster/rhcluster/cluster/make
-DDEFAULT_CONFIG_DIR=\"/etc/cluster\" -DDEFAULT_CONFIG_FILE=\"cluster.conf\"
-DLOGDIR=\"/var/log/cluster\" -DSYSLOGFACILITY=LOG_LOCAL4
-DRELEASE_VERSION=\"2.99.03\" -DHELPER_PROGRAM -D_FILE_OFFSET_BITS=64
-I/usr/src/upstream/cluster/rhcluster/cluster/gfs-kernel/src/gfs -I/usr/include
-I/usr/src/upstream/cluster/rhcluster/cluster/gfs/gfs_mkfs/../include
-I/usr/src/upstream/cluster/rhcluster/cluster/gfs/gfs_mkfs/../libgfs
-I/usr/include -c -o main.o
/usr/src/upstream/cluster/rhcluster/cluster/gfs/gfs_mkfs/main.c
/usr/src/upstream/cluster/rhcluster/cluster/gfs/gfs_mkfs/main.c: In function
'are_you_sure':
/usr/src/upstream/cluster/rhcluster/cluster/gfs/gfs_mkfs/main.c:224: warning:
ignoring return value of 'fgets', declared with attribute warn_unused_result
Comment 1 Robert Peterson 2008-06-12 17:12:46 UTC 
Created attachment 309108 [details]
Proposed patch

Here is the patch I've tested on x86_64 and ia64.  I'll be pushing it
shortly.
Comment 2 Robert Peterson 2008-06-12 17:25:45 UTC 
Now pushed to master and STABLE2.