Bug 451280

Spec: http://cheekyboinc.spielen-unter-linux.de/xqf.spec
SRPM: http://cheekyboinc.spielen-unter-linux.de/xqf-1.0.5-2.fc9.src.rpm

Changelog:

- Add desktop-file-install for the .desktop file
- Add BuildRequires: GeoIP-devel, qstat
- Remove the dummy libGeoIP.so
- Remove Requires: GeoIP

Spec: http://cheekyboinc.spielen-unter-linux.de/xqf.spec
SRPM: http://cheekyboinc.spielen-unter-linux.de/xqf-1.0.5-3.fc9.src.rpm

Changelog:

- Add --enable-bzip2 for bzip2 data compression
- Add --enable-externalrco (Remote server administration tool)
- Add BuildRequires: readline-devel
- Add correct url for Source:
- Add gtk-update-icon-cache

Spec: http://cheekyboinc.spielen-unter-linux.de/xqf.spec
SRPM: http://cheekyboinc.spielen-unter-linux.de/xqf-1.0.5-4.fc9.src.rpm

Changelog:

- Add new .desktop file source
- Remove BuildRequires: gtk+-devel, glib2-devel
- Remove desktop-file-install --remove-category=X-SuSE-Core-Game and 
{name}.desktop

(Removing NEEDSPONSOR, sponsored by me)

Approved.

- rpmlint is silent
- the package is named according to the Package Naming Guidelines
- the spec file name matches the base package %{name}
- the package meets the Packaging Guidelines
- the package is licensed with a Fedora approved license (GPLv2+)
- the License field in the package spec file matches the actual license
- the package includes the text of the license in %doc
- the spec file is written in American English
- the spec file for the package is legible
- the sources used to build the package matches the upstream source
(a88cecba6abb6349107ab135f1009946)
- the package successfully builds in x86_64 rawhide
- all build dependencies are listed in BuildRequires
- the spec file handles locales properly
- the package owns all directories that it creates
- the package does not contain any duplicate files in the %files listing
- permissions on files are set properly
- the package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT
- the package consistently uses macros
- the package contains code, or permissible content
- files included as %doc don't affect the runtime of the application
- desktop file is installed with desktop-file-install
- the package does not own files or directories already owned by other packages
- at the beginning of %install, the package runs rm -rf $RPM_BUILD_ROOT
- all filenames in rpm packages are valid UTF-8
- the package builds in mock
- the package functions as described
- scriptlets are sane


Few minor points, but not blockers:

- it's not necessary to buildrequire glibc-devel, it's already required by gcc
- it's probably better to call desktop-file-install after the upstream desktop
file is removed, to avoid removing the installed file in case they both have the
same name
- maybe it would be better to patch the upstream desktop file instead of
creating new one from scratch to keep the translated comments?

Thank you for the Review!
I will look at this minor points.

New Package CVS Request
=======================
Package Name: xqf
Short Description: a server browser for many popular games
Owners: cheekyboinc
Branches: F-8 F-9
InitialCC:
Cvsextras Commits: yes

cvs done.

xqf-1.0.5-5.fc8 has been submitted as an update for Fedora 8

xqf-1.0.5-5.fc9 has been submitted as an update for Fedora 9

xqf-1.0.5-5.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

xqf-1.0.5-5.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.