Bug 451405

Add dependency on the python-tempita review bug (#451406).  This will also
depend on WebOb (which hasn't been submitted yet).  

Currently this builds but doesn't install due to the missing WebOb dependency. 
Did you intend to submit that or was someone else going to do so?

Yup, this was intentional (as part of an effort to get everything packaged to be
ready to support turbogears2).  I spoke to spot, who had already packaged, but
not submitted a WebOb package, and I'll be submitting that package myself shortly.  

Remove it from the queue until python-Web0b is submitted; just clear the
whiteboard when it's ready.

Readd to queue (python-webob has been submitted)

Some changes:
* Thu Jul 17 2008 Ricky Zhou <ricky> - 0.8-3
- Update Requires for python-webob rename.
- Add BuildRequires on python-webob and python-webtest.

* Mon Jul 07 2008 Ricky Zhou <ricky> - 0.8-2
- Add %%check section.

Spec URL: http://ricky.fedorapeople.org/pkgs/python-weberror/python-weberror.spec
SRPM URL:
http://ricky.fedorapeople.org/pkgs/python-weberror/python-weberror-0.8-3.fc9.src.rpm

http://lmacken.fedorapeople.org/rpms/python-weberror-0.9-1.fc9.src.rpm
http://lmacken.fedorapeople.org/rpms/python-weberror.spec

* Tue Oct 21 2008 Luke Macken <lmacken> - 0.9-1
- Update to 0.9
- Add python-tempita to the BuildRequires

http://lmacken.fedorapeople.org/rpms/python-weberror-0.9-2.fc9.src.rpm
http://lmacken.fedorapeople.org/rpms/python-weberror.spec

* Tue Oct 21 2008 Luke Macken <lmacken> - 0.9-2
- Add a patch to remove the wsgiref requirement, as it is now in Python2.5

This one has been sitting for a bit.  I'll take a look.

It builds fine on rawhide; rpmlint says:
  python-weberror.noarch: W: incoherent-version-in-changelog 0.9-3 ['0.9-2.fc11', 
   '0.9-2']
The last changelog entry is for release 3 but the package is still at release 2.

I note that 0.9.1 is out.  Did you want to update?

Strange, I didn't see any weird release when I looked - maybe Luke fixed that.  Here's a new release with the updated version:

Spec URL: http://ricky.fedorapeople.org/pkgs/python-weberror/python-weberror.spec
SRPM URL: http://ricky.fedorapeople.org/pkgs/python-weberror/python-weberror-0.9.1-1.fc10.src.rpm

As for the release weirdness, note that the spec in comment 7 and the spec inside the src.rpm from comment 7 are not identical.

In any case, let me do a full review.

I might suggest that you expand the "WSGI" acronym in the description; I was curious as to what SGI was up to until I looked it up.  I don't think it's a big deal, though.

I do want to make sure that you're aware that this seems to bundle its own copy of at least part of jquery, which might fall afoul of future javascript packaging guidelines.

* source files match upstream.  sha256sum:
   0ab082270ceaf67de2761a521b1307b5869f790542fca8496d5fc029b62b1d0f  
   WebError-0.9.1.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   python-weberror = 0.9.1-1.fc11
  =
   python(abi) = 2.6
   python-pygments
   python-simplejson
   python-tempita
   python-webob

* %check is present and all tests pass:
   Ran 16 tests in 0.339s
   OK

* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

New Package CVS Request
=======================
Package Name: python-weberror
Short Description: Web Error handling and exception catching middleware
Owners: lmacken, ricky
Branches: F-10 F-9 EL-5

cvs done.

I note that this package is in rawhide but doesn't seem to have been pushed to any  of the release branches.  I see a build for F-10 but nothing for F-9 (not sure how to check EPEL).

If you really wanted this package in the release branches, please build it for them and issue updates in bodhi.  Otherwise, please go ahead and close this ticket.

python-weberror-0.10.1-1.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/python-weberror-0.10.1-1.fc10

python-weberror-0.10.1-1.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/python-weberror-0.10.1-1.fc9

Tagged, built, and submitted for F-10 and F-9 updates.  Thanks!

python-weberror-0.10.1-1.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

python-weberror-0.10.1-1.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

Package Change Request
======================
Package Name: python-weberror
New Branches: epel7
Owners: ralph

Git done (by process-git-requests).