Bug 451666
| Summary: | 0.4.3 in updates-testing doesn't seem to work with ruby-libvirt bindings | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Chris Lalancette <clalance> | ||||
| Component: | ruby-libvirt | Assignee: | David Lutterkort <lutter> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | low | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 9 | CC: | apevec, berrange, hbrock, mastahnke | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | 0.4.4-1.fc9 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2008-07-01 05:30:20 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Chris Lalancette
2008-06-16 15:34:06 UTC
Please re-run with LIBVIRT_DEBUG=1 environment variable set so that it includes debug output. This should tell us where the invalid argument is coming from. Created attachment 309582 [details]
Output from the ruby program with LIBVIRT_DEBUG=1 set
I'm attaching the entire output of the program with LIBVIRT_DEBUG=1 set, but I
believe the relevant part is:
DEBUG: libvirt.c: virConnectListDefinedStoragePools (conn=0xccf1d0,
names=0xc26dd0, maxnames=0)
libvir: error : invalid argument in virConnectListDefinedStoragePools
./storage.rb:25:in `list_defined_storage_pools': Call to function
virConnectListDefinedStoragePools failed (Libvirt::RetrieveError)
from ./storage.rb:25:in `create_pool'
from ./storage.rb:54
DEBUG: libvirt.c: virConnectClose (conn=0xccf1d0)
DEBUG: libvirt.c: virConnectListDefinedStoragePools (conn=0xccf1d0, names=0xc26dd0, maxnames=0) This shows the problem. The ruby bindings should not be using a maxnames value of 0. FYI: I posted a patch for this issue to the libvirt mailing list today. Chris Lalancette Path for the patch in the archive: https://www.redhat.com/archives/libvir-list/2008-June/msg00175.html Daniel IMHO the underlying driver which failed need to be fixed as 0 is an accepted value. Once done applying the patch on the binding to shortcut the function call may be okay as a local optimization (but you loose the argument checkings). Daniel OK. I actually figured out what was really going on here, and I've posted a patch to fix the underlying libvirt problems as well: https://www.redhat.com/archives/libvir-list/2008-June/msg00209.html That being said, I think the patch for the ruby bindings is a good optimization, so I think both patches are useful. Chris Lalancette I agree, the patch for ruby-libvirt looks good and I'll commit it shortly. I committed the patch with a couple more places to shortcircuit added. Making a release and pushing an update will likely have to wait till next week. Cool, thanks David! Chris Lalancette libvirt-0.4.4-1.fc9 has been submitted as an update for Fedora 9 libvirt-0.4.4-1.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update libvirt'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2008-5736 libvirt-0.4.4-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. |