Bug 451773
| Summary: | Review Request: window-picker-applet - an alternative window chooser for small screens | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Yaakov Nemoy <loupgaroublond> | ||||
| Component: | Package Review | Assignee: | Tim Lauridsen <tim.lauridsen> | ||||
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | rawhide | CC: | bnocera, christoph.wickert, fedora-package-review, jonathan.roberts.uk, jreznik, michel, notting, tim.lauridsen | ||||
| Target Milestone: | --- | Flags: | tim.lauridsen:
fedora-review?
|
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2009-09-14 21:51:31 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 462851 | ||||||
| Attachments: |
|
||||||
|
Description
Yaakov Nemoy
2008-06-17 10:01:27 UTC
Created attachment 309634 [details]
spec file cleanup
Attached is an initial patch to cleanup the spec file somewhat. With this the
srpm created passes rpmlint. It probably needs some extra build reqs. You also
need to change the name/email in the Changelog entry.
I think there possibly should also be some post install gconf stuff too but
need to check that out further. Someone in the know should be able to confirm
it.
Updated the spec file to make it comply with packaging guidelines better, as well as renamed to remove Ubuntu from the name. SPEC File: http://ynemoy.fedorapeople.org/repo/window-picker-applet.spec SRPM File: http://ynemoy.fedorapeople.org/repo/window-picker-applet-0.2-1.fc9.src.rpm Have spoken with Yaakov, and will likely co-maintain these packages. I will review this one: Initial comments: Requires and BuildRequires are missing libpanelapplet-2.0 gtk+-2.0 gconf-2.0 libwnck-1.0 and maybe others URL should point to upstream home page not to source URL should be Source0: http://launchpadlibrarian.net/14942872/window-picker-applet_%(version).tar.gz forgot the URL https://launchpad.net/netbook-remix is the closest to and upstream homepage. and Source0 shall point to http://launchpadlibrarian.net/14942872/window-picker-applet_%(version).tar.gz I've spoken to upstream and new source tarballs are due out next week, so I'll hold on making these fixes and changing the source details until then. They've also committed to making more regular releases that will be better to use. Sounds good, maybe you should talk to upstream about making the source tarballs
more standard windows-picker-applet-%{version}.tar.gz, instead of _%{version}.
in ume-launcer it is even more needed the fix the tarball to
ume-launcher-%{version}.tar.gz.
Have done so already :) They said that with the current speed of development, they're really pushed for time and not always able to do make dist for every release and update configure.ac. They have said though that they'll endeavour to make more releases in the future, now that they know others are using their code. Just like in bug #451768 I suggest to rename this package to gnome-applet-window-picker (with a "Provides: window-picker-applet"). See http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Addon_Packages_.28General.29 *** Bug 498200 has been marked as a duplicate of this bug. *** Yaakov, are you still interested in packaging this? I've been running my own window-picker-applet for a while, I can take over the packaging if you want. Desperately need the extra vertical pixels that w-p-a + maximus gives :) Feel free to take this over, i have no interest in this package, since i don't use Gnome anymore. Thanks; I just filed the review request. Tim, would you like to continue with the review? I addressed your concern with package naming. And the 0.5 series is much more visually attractive too. *** This bug has been marked as a duplicate of bug 523326 *** |