Bug 452195
| Summary: | Review Request: Presto - A tilemap engine using the Allegro game programming library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peter Fernandes <supersonicandtails> |
| Component: | Package Review | Assignee: | Ignacio Vazquez-Abrams <ivazqueznet> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, mattia.verga, mtasaka |
| Target Milestone: | --- | Flags: | ivazqueznet:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://www.hypersonicsoft.org/projects/showproject.php?id=29 | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-05-27 16:42:12 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Peter Fernandes
2008-06-20 02:40:33 UTC
I forgot to mention that I'm the upstream developer for this package. I have a project page on my website for the library, found here: http://www.hypersonicsoft.org/projects/showproject.php?id=29. I'm an experienced C programmer, and I definitely appreciate anyone who is willing to help me with this first package! - Descriptions should be wrapped at 79 characters - Examples, README, and COPYING should be in %doc - Changelog entries should be separated by a newline - Fails to build in mock on F8/i386 and F9/i386 - -devel is missing a Requires of allegro-devel, and should have no BuildRequires I've fixed the errors you pointed out, Ignacio, as well as a few other things. Most notably, Presto no longer links with Allegro during build. This is because Allegro contains some non-PIC assembly code that rpmlint doesn't want to allow. rpmlint now complains about undefined references to Allegro functions due to not linking, but the end user can link with Allegro when using Presto. The only other solution to this would be to either remove or change the assembly code in Allegro, neither of which I want to do. Here are the updated SRPM and spec links. I've built the SRPM using mock with no errors, and gotten rid of all the rpmlint errors. http://www.hypersonicsoft.org/projects/downloads/Presto/misc/presto-0.1.1-6.fc9.src.rpm http://www.hypersonicsoft.org/projects/downloads/Presto/misc/presto.spec Thanks! Links changed: http://www.hypersonicsoft.org/projects/downloads/Presto/release/presto.spec http://www.hypersonicsoft.org/projects/downloads/Presto/release/presto-0.1.1-6.fc9.src.rpm I have more changes than I thought to make to the package. I'll update the links once again tomorrow. Here's the update: http://www.hypersonicsoft.org/projects/downloads/Presto/release/presto-0.1.3-1.fc9.src.rpm http://www.hypersonicsoft.org/projects/downloads/Presto/release/presto.spec The package builds cleanly on at least Fedora i386 and x86_64 systems. rpmlint gives no errors (but still the tolerable warnings that I mentioned above). Thanks! - -devel is missing a Requires of allegro-devel, and should have no BuildRequires
>> The -devel package depends on the main package, which depends on allegro-devel.
(In reply to comment #7) > - -devel is missing a Requires of allegro-devel, and should have no BuildRequires > >> The -devel package depends on the main package, which depends on allegro-devel. No, the main package has allegro-devel as a BuildRequires. Software built using presto-devel will fail due to the fact that presto.h (in presto-devel) requires allegro.h (in allegro-devel), but presto-devel does not require allegro-devel. Touché. ;) http://www.hypersonicsoft.org/projects/downloads/Presto/release/presto-0.1.3-2.fc9.src.rpm http://www.hypersonicsoft.org/projects/downloads/Presto/release/presto.spec Requires added. > qmake-qt4 PREFIX="%{buildroot}/%{_prefix}" \
> LIBFINALDIR="%{buildroot}/%{_libdir}"
That's invalid, this should be just:
qmake-qt4 PREFIX="%{_prefix}" LIBFINALDIR="%{_libdir}"
and then use:
make install DESTDIR="%{buildroot}"
instead of just make install.
Actually, with qmake, you have to use:
make install INSTALL_ROOT="%{buildroot}"
(INSTALL_ROOT, not DESTDIR)
Thanks for the heads-up, Kevin. Update: http://www.hypersonicsoft.org/projects/downloads/Presto/release/presto-0.1.3-3.fc9.src.rpm http://www.hypersonicsoft.org/projects/downloads/Presto/release/presto.spec From rpmlint: presto-0.1.3-3.fc8.src.rpm: presto.src: E: no-cleaning-of-buildroot %clean Looks like you have a $ in %clean where you should have a %. presto-devel-0.1.3-3.fc8.i386.rpm: presto-devel.i386: W: spurious-executable-perm /usr/share/doc/presto-0.1.3/examples/build This one I'm willing to let slide. Just fix the error in %clean and this one is approved. http://www.hypersonicsoft.org/projects/downloads/Presto/release/presto.spec http://www.hypersonicsoft.org/projects/downloads/Presto/release/presto-0.1.3-4.fc9.src.rpm I fixed the clean section, and got rid of the other rpmlint warning. New Package CVS Request ======================= Package Name: presto Short Description: A tilemap engine using the Allegro game programming library Owners: hypersonic Branches: F-8 F-9 InitialCC: hypersonic Cvsextras Commits: yes cvs done. I just watch the commit log of this package but directory ownership issue is not correctly addressed. Please fix it (i.e. make it sure that all directories which are created when installing this package are correctly owned by this package) This package was approved and imported in repositories and it was later retired, but this review ticket was never closed. I'm closing it now. |