Bug 452324
| Summary: | Review Request: lxterminal - Desktop-independent VTE-based terminal emulator | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Christoph Wickert <christoph.wickert> |
| Component: | Package Review | Assignee: | Miroslav Lichvar <mlichvar> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | mlichvar:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-07-04 22:16:32 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 505781 | ||
|
Description
Christoph Wickert
2008-06-20 23:08:00 UTC
Miroslav, please wait a moment, I'm going to upload 0.1.3. The spec file is cleanly written, everything seems good.
- rpmlint is silent
- the package is named according to the Package Naming Guidelines
- the spec file name matches the base package %{name}
- the package meets the Packaging Guidelines
- the package is licensed with a Fedora approved license
- the License field in the package spec file matches the actual license (GPLv2+)
- the package includes the text of the license in %doc
- the spec file is written in American English
- the spec file for the package is legible
- the sources used to build the package matches the upstream source
- the package successfully builds in x86_64 and ppc rawhide
- all build dependencies are listed in BuildRequires
- the spec file handles locales properly
- the package owns all directories that it creates
- the package does not contain any duplicate files in the %files listing
- permissions on files are set properly
- the package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT
- the package consistently uses macros
- the package contains code, or permissible content
- files included as %doc don't affect the runtime of the application
- desktop file is installed with desktop-file-install
- the package does not own files or directories already owned by other packages
- at the beginning of %install, the package runs rm -rf $RPM_BUILD_ROOT
- all filenames in rpm packages are valid UTF-8
- the package functions as described (tested only on x86_64)
Approved.
The sed line in %prep can be removed, the typo was fixed in 0.1.3.
(In reply to comment #3) > The sed line in %prep can be removed, the typo was fixed in 0.1.3. Good catch (although I should have known that because I was the one who informed upstream about the typo). Will fix that after the import. Thanks for the review! New Package CVS Request ======================= Package Name: lxterminal Short Description: Desktop-independent VTE-based terminal emulator Owners: cwickert Branches: F-8 F-9 InitialCC: Cvsextras Commits: yes cvs done. lxterminal-0.1.3-1.fc9 has been submitted as an update for Fedora 9 lxterminal-0.1.3-1.fc8 has been submitted as an update for Fedora 8 lxterminal-0.1.3-1.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. lxterminal-0.1.3-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. lxterminal-0.1.3-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: lxterminal New Branches: EL-4 EL-5 Owners: cwickert cvs done. |