Bug 452470
| Summary: | Review-Request: perl-Test-WWW-Selenium - Perl Client for the Selenium Remote Control test tool | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lubomir Rintel <lkundrak> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://netbsd.sk/~lkundrak/SPECS/perl-Test-WWW-Selenium.spec | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-07-01 18:01:01 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 452471 | ||
| Bug Blocks: | |||
|
Description
Lubomir Rintel
2008-06-23 07:57:11 UTC
Add Apache to License tag also. Build failed http://koji.fedoraproject.org/koji/taskinfo?taskID=676057 Found missing perl(Test::Mock::LWP) Apache License Added. As you correctly found out Tess::Mock::LWP is pending adding to Fedora. Thanks for adding the dependency! SPEC: http://netbsd.sk/~lkundrak/SPECS/perl-Test-WWW-Selenium.spec SRPM: http://netbsd.sk/~lkundrak/mock-results/perl-Test-WWW-Selenium-1.15-1.el5.noarch/perl-Test-WWW-Selenium-1.15-2.el5.src.rpm The reason I have not done review of this is that I am repeatedly getting 404 error for SRPM download still. Parag: I'm sorry for that. The correct URL is: http://netbsd.sk/~lkundrak/mock-results/perl-Test-WWW-Selenium-1.15-2.el5.noarch/perl-Test-WWW-Selenium-1.15-2.el5.src.rpm Thanks! Review: + package builds in mock. koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=686732 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 932a71581ebfaad8bc544aa1eae39c5e Test-WWW-Selenium-0.15.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test All tests successful, 1 test skipped. Files=8, Tests=239, 1 wallclock secs ( 1.14 cusr + 0.04 csys = 1.18 CPU) APPROVED. New Package CVS Request ======================= Package Name: perl-Test-WWW-Selenium Short Description: Perl Client for the Selenium Remote Control test tool Owners: lkundrak Branches: F-8 F-9 EL-5 Cvsextras Commits: yes cvs done. Imported and built. Thanks! |