Bug 452523
Summary: | Review Request: perl-Event-ExecFlow - High level API for event-based execution flow control | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Nicolas Chauvet (kwizart) <kwizart> |
Component: | Package Review | Assignee: | Xavier Bachelot <xavier> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting, xavier |
Target Milestone: | --- | Flags: | xavier:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-07-24 22:19:44 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 452516 | ||
Bug Blocks: |
Description
Nicolas Chauvet (kwizart)
2008-06-23 15:00:15 UTC
missing BuildRequires : Warning: prerequisite Locale::TextDomain 0 not found. Warning: prerequisite Test::More 0 not found. Spec URL: http://kwizart.fedorapeople.org/SPECS/perl-Event-ExecFlow.spec SRPM URL: http://kwizart.fedorapeople.org/SRPMS/perl-Event-ExecFlow-0.63-2.fc8.kwizart.src.rpm Description: High level API for event-based execution flow control changelog - Add BR Test::More and Locale::TextDomain + source files match upstream : 79116732b550701a3436a448581e01da + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + dist tag is present. + build root is correct. - license field matches the actual license : The README file says same license as perl, thus GPL+ or Artistic, but most files say LGPLv2+ + license is open source-compatible. License text not included upstream. + latest version is being packaged. + BuildRequires are proper. + compiler flags are appropriate. + %clean is present. + package builds in mock ( ). + package installs properly - rpmlint is silent : perl-Event-ExecFlow.noarch: E: non-standard-executable-perm /usr/bin/execflow 0555 perl-Event-ExecFlow.noarch: W: file-not-utf8 /usr/share/doc/perl-Event-ExecFlow-0.63/README - final provides and requires are sane: This provide is dubious : perl(AnyEvent::Impl::Event::Glib) + %check is present and all tests pass + owns the directories it creates. - doesn't own any directories it shouldn't. The directories below are installed and owned : /usr/lib/perl5/vendor_perl/5.10.0/i386-linux-thread-multi /usr/lib/perl5/vendor_perl/5.10.0/i386-linux-thread-multi/auto /usr/lib/perl5/vendor_perl/5.10.0/i386-linux-thread-multi/auto/Event /usr/lib/perl5/vendor_perl/5.10.0/i386-linux-thread-multi/auto/Event/ExecFlow + no duplicates in %files. + file permissions are appropriate. + no scriptlets present. + code, not content. + documentation is small, so no -docs subpackage is necessary. + %docs are not necessary for the proper functioning of the package. Spec URL: http://kwizart.fedorapeople.org/SPECS/perl-Event-ExecFlow.spec SRPM URL: http://kwizart.fedorapeople.org/SRPMS/perl-Event-ExecFlow-0.63-3.fc8.kwizart.src.rpm Description: High level API for event-based execution flow control Changelog - Fix directory ownership - Fix execflow perm - Fix perl Encoding - Fix License to LGPLv2+ And fix AnyEvent::Impl::Event::Glib wrong provides as it was already provided by perl-AnyEvent (good catch). Looks good, the last remaining point is the license. As I previously noted, all .pm files are LGPLv2+, only lib/Event/ExecFlow.pm is GPL+ or Artistic. The README also says GPL+ or Artistic. I'm not sure this makes the whole package LGPLv2+, but my license-fu is weak. Well, each source file applies a license of it's own, with inlined licenses overruling detached licenses. I.e. as all *.pm's carry an explicit license, the global README is mostly void. => This package contains both "GPL+ or Artistic" files and "LGPL'ed" files. Now the big (and controversal) question is: a) Are perl-modules linked or b) are they simply calling each other? If a) applies, the only way to ship this package is to relicense it as "GPL+"-only (LGPL'ed code can be changed to GPL) If b) applies, this discussion is moot. I think b) applies, but IANAL. So, what to do with this ? I think it would do a (GPL+ or Artistic) and LGPLv2+ with a note like: # This file is GPL+ or Artistic %{_bindir}/execflow # Theses files are LGPLv2+ %{perl_vendorlib}/Event/ %{_mandir}/man3/*.3* (In reply to comment #7) > So, what to do with this ? I think it would do a > (GPL+ or Artistic) and LGPLv2+ > > with a note like: > # This file is GPL+ or Artistic > %{_bindir}/execflow > # Theses files are LGPLv2+ > %{perl_vendorlib}/Event/ > %{_mandir}/man3/*.3* > > I've checked the licensing guidelines and with this change the package is APPROVED. New Package CVS Request ======================= Package Name: perl-Event-ExecFlow Short Description: High level API for event-based execution flow control Owners: kwizart Branches: F-8 F-9 EL-4 EL-5 InitialCC: perl-sig Cvsextras Commits: yes cvs done. |