Bug 452805 (ember)
Summary: | Review Request: ember - WorldForge client | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Alexey Torkhov <atorkhov> |
Component: | Package Review | Assignee: | Tom "spot" Callaway <tcallawa> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | che666, fedora-package-review, huzaifas, notting, pahan, tcallawa, wart |
Target Milestone: | --- | Flags: | tcallawa:
fedora-review+
huzaifas: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-09-12 07:26:28 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Alexey Torkhov
2008-06-25 08:01:57 UTC
Spec URL: http://purple.worldforge.org/~alex/fedora/ember.spec SRPM URL: http://purple.worldforge.org/~alex/fedora/ember-0.5.3-1.fc10.src.rpm Update to 0.5.3. All patches are now merged. License upgraded to GPLv3+. Spec URL: http://purple.worldforge.org/~alex/fedora/ember.spec SRPM URL: http://purple.worldforge.org/~alex/fedora/ember-0.5.4-1.fc10.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=819928 Update to 0.5.4. REVIEW ========== Good: - rpmlint checks return: ember.x86_64: W: conffile-without-noreplace-flag /etc/ember/ogre.cfg ember.x86_64: W: conffile-without-noreplace-flag /etc/ember/resources.cfg ember.x86_64: W: conffile-without-noreplace-flag /etc/ember/terrain.cfg Documented why you didn't do this, safe to ignore. - package meets naming guidelines - package meets packaging guidelines - license (GPLv3+) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream (f5d94ac46131bcf0bb7788e311331aac523287b8) - package compiles on devel (x86_64, koji scratch) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - desktop file ok Nice job with this package, APPROVED. Many thanks for review! New Package CVS Request ======================= Package Name: ember Short Description: 3D client for WorldForge Owners: atorkhov wart Branches: F-9 InitialCC: cvs done |