Bug 452944

I think script should be like this:

#!/bin/sh -f
#
# Copyright (c) 2006 Silicon Graphics, Inc.  All Rights Reserved.
#

AUTO=false
while getopts ":aAy" c
do
        case $c in
        a|A|y)  AUTO=true;;
        esac
done
if $AUTO; then
        echo "$0: XFS file system."
else
        eval DEV=\${$#}
        if [ ! -e $DEV ]; then
                echo "$0: $DEV does not exist"
                exit 8
        fi
        echo "If you wish to check the consistency of an XFS filesystem or"
        echo "repair a damaged filesystem, see xfs_check(8) and xfs_repair(8)."
fi
exit 0

Is /dev/sdf a removable drive, and is it present at boot time?  It seems strange
that fsck would be called for a device which doesn't exist?

No. the device is not present. That's the point. If device is present there are
no errors.

And, no. It's not strange at all. Default behavior of /sbin/fsck -A from man
(run bye rc.sysconfig):

       -A     Walk through the /etc/fstab file and try to check all file  sys-
              tems in one run.  This option is typically used from the /etc/rc
              system initialization file, instead  of  multiple  commands  for
              checking a single file system.

In xfsprogs which work OK is xfsprogs-2.9.4-4 from Fedora 8.
xfsprogs-2.9.7 (fedora 9) have the fsck.xfs script modified. And the
modifications are not working as expected.


Gabriel

I'll ask the sgi guys why the check was put in there.  Maybe it is just the
wrong error code returned.  If fsck is asked to check a device that does not
exist, I assume that it should not just return success, but I'll double-check
(looking at what e2fsck does, now)

I'm not saying that today's behavior is proper, and I agree that it needs to be
fixed, just thinking out loud about what's going on, and the proper way to fix it.

Thanks,

-Eric

FWIW:

[root@neon ~]# e2fsck /dev/sdzz
e2fsck 1.40.4 (31-Dec-2007)
e2fsck: No such file or directory while trying to open /dev/sdzz
...
[root@neon ~]# echo $?
8

This actually appears to be proper behavior, you'd see the same thing with
e2fsprogs (even in F8 and earlier) if you had ext3 on the drive.

Talking w/ notting (keeper of the initscripts) he points out that "noauto +
autofsck doesn't really make sense" and really you cannot reliably ask for
autofsck of removable media at boot time.

While it would be nice, I do not think there is any mechanism to say "fsck and
mount this device if it is available, otherwise continue"

I think your best bet is to just end the fstab line with "0 0" so that it does
not check at boot time (and fsck.xfs does not do anything anyway, so you're not
losing any safety).

I'm going to NOTABUG this, really I think you just got "lucky" in F8 because
fsck.xfs was (improperly) not returning any error when the requested device was
missing.

Thanks,

-Eric

(In reply to comment #5)
> This actually appears to be proper behavior, you'd see the same thing with
> e2fsprogs (even in F8 and earlier) if you had ext3 on the drive.
You're right.

> While it would be nice, I do not think there is any mechanism to say "fsck and
> mount this device if it is available, otherwise continue"
Well, a small  script can do this.

> I think your best bet is to just end the fstab line with "0 0" so that it does
> not check at boot time
Right again.

> (and fsck.xfs does not do anything anyway, so you're not
> losing any safety).
Yes, I know that.

> I'm going to NOTABUG this, really I think you just got "lucky" in F8 because
> fsck.xfs was (improperly) not returning any error when the requested device
> was missing.
OK.
But it's not only in Fedora 8. I use that line from fstab in RedHat 9, Fedora 1
to 8 (yes, I still use RH9 :-) ).


Thank you.

Sincerely,
Gabriel

> But it's not only in Fedora 8. I use that line from fstab in RedHat 9, Fedora 1
> to 8 (yes, I still use RH9 :-) ).

And using xfs since all that time, I'm impressed!  :)