Bug 453082
| Summary: | Review Request: python-dtopt - Add options to doctest examples while they are running | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ricky Zhou <rickyz> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | j:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-07-16 01:07:00 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 455111 | ||
|
Description
Ricky Zhou
2008-06-27 06:41:09 UTC
Builds fine, rpmlint is silent. I admit to not being able to understand anything at all about the summary or even the description, I can't even understand enough of them to suggest improvements. I suppose someone who knows something of the subject matter would understand them, but I would suggest trying to make it a little more readable if you can. I guess my issue is that %description seems more like the documentation for the package instead of a short overview of what it does. Still, perhaps I'm just daft, and the packaging itself looks fine. * source files match upstream: 06ae07a12294a7ba708abaa63f838017d1a2faf6147a1e7a14ca4fa28f86da7f dtopt-0.1.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: python-dtopt = 0.1-2.fc10 = python(abi) = 2.5 * %check is not present; no test suite upstream. I've no idea how to test this. * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED Thanks! I wasn't sure how to simplify the description, because that's pretty much all it does (allow you to use ELLIPSIS and other options without #doctest: +ELLIPSIS, etc. in tests). New Package CVS Request ======================= Package Name: python-dtopts Short Description: Add options to doctest examples while they are running Owners: ricky Branches: F-8 F-9 InitialCC: Cvsextras Commits: yes cvs done. Sorry - another stupid mistake on my part - it should be python-dtopt (no s). I've already changed it in pkgdb, so just the CVS part of https://fedoraproject.org/wiki/Infrastructure/SOP/PackageDB#Renaming_a_package should be required. Thanks! This looks to be all done. Let me know if there is further action required. python-dtopt-0.1-2.fc9 has been submitted as an update for Fedora 9 python-dtopt-0.1-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. Weird, that should have closed this bug - closing manually. Package Change Request ====================== Package Name: python-dtopt New Branches: EL-4 EL-5 cvs done. |