Bug 453395 (libmapi)

First suggestion, drop the Epoch.

Updated packages will continue to be placed at http://abartlet.net/openchange-rpm/

I can review this (and help with samba4 more later, that one's going to take
more time).

1.  SHOULD drop Epoch

2.  drop extraneous:
Requires(post): /sbin/ldconfig
Requires(postun): /sbin/ldconfig

3.  SHOULD drop extraneous
Requires: libtalloc >= 0:%{talloc_version}
which is already satisfied by fedora's default repos (F9+ anyway)

Can't confirm buildability atm, lacking samba4 builds here.  I think we can
trust you an that. :)

This one is pretty small/simple and the only items I found were mostly cosmetic,
so I'll also trust you to address them before performing any builds.

APPROVED.

I should have mentioned, I will need to be sponsored, as this is one of my first
packages (ie, with the others in this chain).

Updated packages addressing the above (and incorporating a name change to openchange, on the request of upstream) is now on my website.

Taking over this effort for the time being to get evolution-mapi approved.

I've updated the OpenChange package to the current Subversion revision.

SPEC:
http://mbarnes.fedorapeople.org/mapi/SPECS/openchange.spec

SRPM:
http://mbarnes.fedorapeople.org/mapi/SRPMS/openchange-0.8-0.3.svn909.fc10.src.rpm

Changes from Andrew's latest revision:
http://mbarnes.fedorapeople.org/mapi/SPECS/openchange.spec.diff

Doesn't this also need a "BuildRequires: autoconf sysconftool automake libtool flex zlib-devel bison"?

rpmlint output for the SRPM:
openchange.src:132: W: macro-in-%changelog post
openchange.src: W: mixed-use-of-spaces-and-tabs (spaces: line 6, tab: line 8)
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

rpmlint output for the resulting RPMs:
openchange.i386: W: no-documentation
openchange.i386: E: library-without-ldconfig-postin /usr/lib/libmapi.so.0.8
openchange.i386: E: library-without-ldconfig-postun /usr/lib/libmapi.so.0.8
openchange.i386: E: library-without-ldconfig-postin /usr/lib/libocpf.so.0.8
openchange.i386: E: library-without-ldconfig-postun /usr/lib/libocpf.so.0.8
openchange.i386: E: library-without-ldconfig-postin /usr/lib/libmapiadmin.so.0.8
openchange.i386: E: library-without-ldconfig-postun /usr/lib/libmapiadmin.so.0.8
openchange.i386: W: incoherent-version-in-changelog 0:0.8-0.3.svn960.fc9 ['0.8-0.3.svn909.fc10', '0.8-0.3.svn909']
openchange.i386: W: shared-lib-calls-exit /usr/lib/libmapi.so.0.8 exit
openchange.i386: W: shared-lib-calls-exit /usr/lib/libocpf.so.0.8 exit
4 packages and 0 specfiles checked; 6 errors, 4 warnings.

On rawhide, I see this:
$ rpmlint Download/openchange-0.8-0.3.svn909.fc10.src.rpm
/usr/share/rpmlint/Pkg.py:16: DeprecationWarning: The popen2 module is deprecated.  Use the subprocess module.
  import popen2
openchange.src:132: W: macro-in-%changelog post
openchange.src: W: mixed-use-of-spaces-and-tabs (spaces: line 6, tab: line 8)
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

Update.  Think I got most of the rpmlint stuff.

http://mbarnes.fedorapeople.org/mapi/SPECS/openchange.spec
http://mbarnes.fedorapeople.org/mapi/SRPMS/openchange-0.8-0.5.svn909.fc10.src.rpm

my apologies, my time/interest has waned, so I'll withdraw to let someone else jump in.

Updated to a more recent SVN revision.

http://mbarnes.fedorapeople.org/mapi/SPECS/openchange.spec
http://mbarnes.fedorapeople.org/mapi/SRPMS/openchange-0.8-0.6.svn949.fc10.src.rpm

(resetting all)

Still needs BuildRequires: zlib-devel

(In reply to comment #15)
> Still needs BuildRequires: zlib-devel

Fixed:

http://mbarnes.fedorapeople.org/mapi/SPECS/openchange.spec
http://mbarnes.fedorapeople.org/mapi/SRPMS/openchange-0.8-0.7.svn949.fc10.src.rpm

Update to official 0.8 ("ROMULUS") release.  Introduces a new openchange-python subpackage with Python bindings for the libmapi API.

http://mbarnes.fedorapeople.org/mapi/SPECS/openchange.spec
http://mbarnes.fedorapeople.org/mapi/SRPMS/openchange-0.8-1.fc10.src.rpm

Update adds some missing BuildRequires.

http://mbarnes.fedorapeople.org/mapi/SPECS/openchange.spec
http://mbarnes.fedorapeople.org/mapi/SRPMS/openchange-0.8-2.fc10.src.rpm

One last update in preparation for a formal review.  Just fixes some minor rpmlint warnings.

http://mbarnes.fedorapeople.org/mapi/SPECS/openchange.spec
http://mbarnes.fedorapeople.org/mapi/SRPMS/openchange-0.8-3.fc10.src.rpm

Package builds ok in mock

rpmlint on the resulting rpms:

openchange.x86_64: W: shared-lib-calls-exit /usr/lib64/libmapi.so.0.8 exit.5
openchange.x86_64: W: shared-lib-calls-exit /usr/lib64/libocpf.so.0.8 exit.5
openchange-python.x86_64: W: no-documentation
openchange-python.x86_64: E: non-executable-script /usr/lib64/python2.6/site-packages/openchange/provision.py 0644
openchange-python.x86_64: E: non-executable-script /usr/lib64/python2.6/site-packages/openchange/__init__.py 0644
6 packages and 0 specfiles checked; 2 errors, 3 warnings.

The warnings are not serious, not sure what to make of the script error, it looks bogus to me.

package name: matches project name, ok
spec file name: ok
packaging guidelines: ok
license: ok
license field: ok, but should it mentioned the idl license ?
license file: ok
spec language: ok
spec legibility: ok
upstream sources: needs to include the full src url
buildable: ok
buildrequires: ok
locale handling: ok
ldconfig: ok
relocatable: ok
directory ownership: ok
duplicate files: ok
file permissions: ok
%clean: ok
macro use: ok
permissible content: ok
large docs: ok
%doc content: ok
header files: ok
static libraries: ok
pkgconfig files: ok
shared libs: ok
devel package deps: ok
libtool archives: ok
gui apps: ok
file ownership: ok
%install: ok
utf8 filenames: ok


summary:
- fix the source url

(In reply to comment #20)
>
> openchange-python.x86_64: E: non-executable-script
> /usr/lib64/python2.6/site-packages/openchange/provision.py 0644
> openchange-python.x86_64: E: non-executable-script
> /usr/lib64/python2.6/site-packages/openchange/__init__.py 0644

You get these errors when a  file starts with "#!<yadda>" but does not have executable permissions.  To get rid of the rpmlint warnings I use:

%{__sed} -i -r -e '/^#!/,1d' <filename>

which will delete the first line if it starts with a "#!"

Source URL fixed.  Updated license tag: the code is GPLv3+ not GPLv3, and the IDL license appears to be public domain.  Most files under site-packages are executable, so I overrode the permissions on those Python files.

http://mbarnes.fedorapeople.org/mapi/SPECS/openchange.spec
http://mbarnes.fedorapeople.org/mapi/SRPMS/openchange-0.8-4.fc10.src.rpm

Hmm, the libmapi-0.8-ROMULUS.tar.gz I get there differs from the one in your srpm.

That's strange, I don't remember where I got the original tarball.  But anyway I rebuilt with the one from SourceForge.

http://mbarnes.fedorapeople.org/mapi/SPECS/openchange.spec
http://mbarnes.fedorapeople.org/mapi/SRPMS/openchange-0.8-5.fc10.src.rpm

Looks good now. Approved

New Package CVS Request
=======================
Package Name: openchange
Short Description: Microsoft Exchange access with native protocols
Owners: mbarnes
Branches: 
InitialCC:

cvs done.

Package built.  Closing review.

http://kojipkgs.fedoraproject.org/packages/openchange/