Bug 453567
Summary: | Review Request: libfonts - Java TrueType Font Layouting | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Caolan McNamara <caolanm> |
Component: | Package Review | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting |
Target Milestone: | --- | Flags: | j:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-07-04 23:05:31 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Caolan McNamara
2008-07-01 12:05:51 UTC
Builds fine for me; rpmlint only has the usual bogus complaint about the Group:. The URL continues to not provide any information about this package, but google doesn't turn up a better URL to use. I can't even find a download link. Is it possible to use a reasonable URL for this package? Maybe just use http://sourceforge.net/projects/jfreereport/, which I found from searching around on sourceforge and which actually has libfonts in the download section. The current release seems to be 0.4.0, out May 30. Any reason not to use it? Here's my checklist for the 0.3.4 version: * source files match upstream: 7c8616aee3b8affc38d96e6cdf96fc49bd4a3834c1452abb189609fbce1f0ea8 libfonts-0.3.4.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. * rpmlint has acceptable complaints. * final provides and requires are sane: libfonts-0.3.4-1.fc10.x86_64.rpm libfonts.jar.so()(64bit) libfonts = 0.3.4-1.fc10 = /bin/sh java java-gcj-compat >= 1.0.31 jcommon jpackage-utils libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcj_bc.so.1()(64bit) libloader >= 0.3.7-1 libz.so.1()(64bit) libfonts-javadoc-0.3.4-1.fc10.x86_64.rpm libfonts-javadoc = 0.3.4-1.fc10 = jpackage-utils libfonts = 0.3.4-1.fc10 * %check is not present; no test suite upstream. * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets OK * code, not content. * %docs are not necessary for the proper functioning of the package. * no pre-built jars * single jar, named after the package * jarfiles are under _javadir. * javadocs are under _javadocdir. * ant called properly. * gcj called properly. As regards the versions, there are 13 (!) dependencies towards jfreereport itself, and these were the latest when I started importing them around the 8th May. There are newer ones now, but unfortunately there is then an additional low level dependency in the new version chain. I'd hoped to get this chain imported before resetting back to the start and adding the new low-level one and updating everything to match that extra dependency. The route from the URL to the relevant section is: http://reporting.pentaho.org/ and "Classic Engine Originally known as JFreeReport," and go to link downloads I could use "http://reporting.pentaho.org/classic_engine.php" which is a new page for the reporting engine formerly known as jfreereport I see what you mean about the dependencies; I found the dependency graph and it's pretty horrendous. There's no requirement that you submit the absolute latest version of something, I just try to make sure that submitters know they're submitting something that's a little out of date. I guess if I get to the downloads page and then pick "Browse All Files" then I can see all of the dependent packages. That's not really ideal, but seems good enough to me. Anyway, there's no reason to hold things up. APPROVED New Package CVS Request ======================= Package Name: libfonts Short Description: Java TrueType Font Layouting Owners: caolanm Branches: InitialCC: Cvsextras Commits: yes cvs done. |