Bug 453613
Summary: | FEAT: md5sum check should have an override for attaching packages | ||
---|---|---|---|
Product: | [Retired] Red Hat Hardware Certification Program | Reporter: | Rob Landry <rlandry> |
Component: | Hardware Catalog | Assignee: | eric_liu <efeng> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Yu Shao <yshao> |
Severity: | low | Docs Contact: | |
Priority: | low | ||
Version: | 5 | CC: | bxu, xiqin, xisun, ykun, yshao |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://hardware.redhat.com | ||
Whiteboard: | |||
Fixed In Version: | 3.2rh-20080801.1 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-08-04 17:57:01 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 169367 | ||
Attachments: |
Description
Rob Landry
2008-07-01 15:17:56 UTC
A New Patch under Rob 's suggestion has been, improve for patching operation: Please review :) Created attachment 311359 [details]
A New patch under rob's suggestion
Created attachment 311524 [details]
A new patch under rob's instruction
A new patch under rob's instruction, fixed:
1. sub validateMd5sumOverride() to verify cgi and user permission;
2. A new error page template for validateMd5sumOverride's permission denies;
2. New Select statement with "JOIN , ON" for multi table;
3. New struction for while @row=fetchrowarray;
4. Add the all the comments with only one variable $comment;
5 . remove the duplicated code in hwcert.pl;
6. update the select-option to input-checkbox for override on UI
Created attachment 311916 [details]
The newest patch has been fixed
Fix the warn sentence on Error page:
"You are not authorized to override the duplicate md5sum check."
Deployed on http://bugdev.devel.redhat.com/hwcert-eric1/ If test pass, will check into cvs. Nicho Patch has been checked into cvs. Thanks, Nicho Sun :) The last patch missed the title text change for the user error as well as a response to the comments of the changes listed in comment #7. Created attachment 312278 [details] a patch fix the comment#7 Created attachment 312754 [details]
a patch fix all of above patches including UI clean
a patch fix all of above patches including UI clean, please review I have already put this patch on bugdev. but the db has been taken down, so please review the source code on bugdev in dir eric2 I have test this patch on my own pc, it could be work well on db of bz2.18 Unfortunately the db is down again before I could review. Is there anything additional to this new patch or is just a combination of the previous patches? If it's new, can you highlight what those changes are in comment; if it's a combination we'll need to review to separate out the portions that are already in CVS from those that aren't to verify functionality. Created attachment 312935 [details]
CVS to updated patch + additional UI and code cleanup
committed to cvs tested and run good |