Bug 453870
| Summary: | Review Request: iw - A nl80211 based wireless configuration tool | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Adel Gadllah <adel.gadllah> |
| Component: | Package Review | Assignee: | Lubomir Rintel <lkundrak> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, linville, notting |
| Target Milestone: | --- | Flags: | lkundrak:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-07-24 13:07:11 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Adel Gadllah
2008-07-02 23:16:03 UTC
Remarks: * You shpuld add comments describin how to create provided in Source0 tarball. E.g.something like: # svn export http://example.com/svn/name/trunk name-1.0.0 # tar cjvf name-1.0.0.tar.bz2 name-1.0.0 Source0: name-1.0.0.tar.bz2 * You may simplify installation process. Instead of mkdir -p $RPM_BUILD_ROOT%{_bindir} install -m 0755 %{name} $RPM_BUILD_ROOT%{_bindir}/%{name} you may do it in the following way: install -D -p -m 0755 %{name} $RPM_BUILD_ROOT%{_bindir}/%{name} Note -p (preserves timestamps) and -D (creates all necessary directories). Thanks for the comments, fixed: http://tgmweb.at/gadllah/iw.spec http://tgmweb.at/gadllah/iw-0.0-0.2.20080703git.fc9.src.rpm Adel: Thanks for the package. 1.) I suggest you version the dependency on kernel-devel. At least headers from el5's 2.6.18 are definitely not enough to build this. 2.) The comment that explains how to generate the source tarball should describe how to reproduce the very same sourece tree, and I guess that I'll get a more recent version if I did a simple git clone now. You should probably add a SHA hash of the tree you are packaging, or whatever nonsense does GIT use instead of revision numbers :) Not really a blockers though -- there's nothing you can do wrong when doing that at import time. In all other respect, the package is perfect. Nice work. RPMlint is happy, SPEC file is sane and legible, compiler flags are honoured. Therefore the package is APPROVED Thanks for the review, I have fixed 1) and 2) (fix will be in the imported package). ---------------------------- New Package CVS Request ======================= Package Name: iw Short Description: A nl80211 based wireless configuration tool Owners: drago01 Branches: F-8 F-9 InitialCC: Cvsextras Commits: yes cvs done. |