Bug 454008
Summary: | Review Request: iax - Implementation of Inter-Asterisk eXchange protocol | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Tom "spot" Callaway <tcallawa> |
Component: | Package Review | Assignee: | Orcan Ogetbil <oget.fedora> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting, oget.fedora, opensource |
Target Milestone: | --- | Flags: | oget.fedora:
fedora-review+
tcallawa: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | 0.2.2-2.fc9 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-03-13 18:36:31 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 454010, 454022 |
Description
Tom "spot" Callaway
2008-07-03 20:04:05 UTC
Is it a problem that iax-client.h and iax.h are GPL and not LGPL? Ehh, the License tag should be GPL+. My mistake. 1. iax.spec.in still refers to the license as LGPL and breaks when I install and build from the source RPM 2. FYI, my rpmbuild failed on Ubuntu (it could not find any .so packages to install). It works on Fedora. Comments 1. The package owns the directories and files it creates 2. ldconfig is run 3. %doc is used correctly 4. Header files and .so are in -devel 5. Main package contains .so.version files 6. -devel package depends on main 7. Package does not contain any .la archives 8. Package does rm -rf %{buildroot} at the beginning of install 9. Package installs to DESTDIR Balbir iax.spec.in is really irrelevant, as I'm not using or packaging the system provided spec file (it really isn't any good). I'm also not surprised that rpmbuild fails on Ubuntu, nor do I care if it works. :) Thanks for the feedback. There should be a comment about the status of your patch in the spec according to: https://fedoraproject.org/wiki/Packaging/PatchUpstreamStatus ok, here are my notes: - rpmlint says: iax-devel.x86_64: W: no-documentation but there is not much we can do about it - the patch is trivial but seems packaging specific. I leave it up to you to send it upstream. * I couldn't check the URL. It doesn't respond. * I think the file iax-config.in needs sed'ded because it assumes the libdir to be $prefix/lib/ ? I suggest making use of the %name macro. Up to you * You might want to kill the rpath * Shouldn't the license field be GPL+ and LGPL+, because some source files are GPL, some are LGPL? (In reply to comment #6) > ok, here are my notes: > > - rpmlint says: > iax-devel.x86_64: W: no-documentation > but there is not much we can do about it Indeed. > * I couldn't check the URL. It doesn't respond. Fixed it to point to the download toplevel dir for iax. > * I think the file iax-config.in needs sed'ded because it assumes the libdir to > be $prefix/lib/ You're right. Fixed in -2. > ? I suggest making use of the %name macro. Up to you I did it everywhere except the libiax.so references. > * You might want to kill the rpath I don't see any bad rpath... /usr/lib/rpm/check-rpaths says it is clean. > * Shouldn't the license field be GPL+ and LGPL+, because some source files are > GPL, some are LGPL? Good catch. New Spec URL: http://auroralinux.org/people/spot/review/coccinella/iax.spec New SRPM URL: http://auroralinux.org/people/spot/review/coccinella/iax-0.2.2-2.fc11.src.rpm Thanks. I saw this on the build.log /bin/sh ../libtool --mode=link gcc -g -Wall -Wstrict-prototypes -I . -DDEBUG_SUPPORT -DDEBUG_DEFAULT -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -o libiax.la -rpath /usr/lib64 iax.lo md5.lo ^^^^^^ I don't know how important this is but "-rpath" is passed to libtool here. Can this be ignored? Orcan, the libtool file is not included in the binary package. Alright then. I wasn't sure. -------------------------------------- This package (iax) is APPROVED by oget -------------------------------------- New Package CVS Request ======================= Package Name: iax Short Description: Implementation of Inter-Asterisk eXchange protocol Owners: spot Branches: F-9 F-10 devel InitialCC: ... and it's done. iax-0.2.2-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/iax-0.2.2-2.fc9 iax-0.2.2-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/iax-0.2.2-2.fc10 iax-0.2.2-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. iax-0.2.2-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. |