Bug 454011
| Summary: | Review Request: tcl-snack - Sound toolkit | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tom "spot" Callaway <tcallawa> |
| Component: | Package Review | Assignee: | Marcela Mašláňová <mmaslano> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, mikhail.kalenkov, notting |
| Target Milestone: | --- | Flags: | mmaslano:
fedora-review+
tcallawa: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-09-13 13:13:33 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 454022 | ||
|
Description
Tom "spot" Callaway
2008-07-03 20:10:20 UTC
Mp3 was removed from code, so I'm ok with that. Licence: if you start changing source files, couldn't be removed BSD.txt file? Whole source is under GPLv2 anyway. I always try to keep my modifications to a minimum in such cases. Lots of packages include extraneous license files (possibly for historical purposes). Ok. Not that I'm complaining here, but could you do a bit more of a review than "Ok". I mean, I'm sure my package is perfect and all... :) For example, look at: http://fedoraproject.org/wiki/TillMaas/ReviewChecklist or http://fedoraproject.org/wiki/SpotsReviewCheatSheet - rpmlint checks return: Nothing - OK - package meets naming guidelines OK - package meets packaging guidelines OK - license (GPLv2+) OK, text in %doc, matches source OK - spec file legible, in am. english - it looks OK for me ;-) - source matches upstream - don't match, because mp3 support was cut - OK - package compiles on devel (x86) - broken koji :( - no missing BR OK - no unnecessary BR OK - no locales OK - not relocatable OK - owns all directories that it creates OK - no duplicate files OK - permissions ok OK - %clean ok OK - macro use consistent OK - code, not content OK - no need for -docs - not needed OK - nothing in %doc affects runtime OK - no need for .desktop file OK Hehe, I read and check this list https://fedoraproject.org/wiki/Packaging/ReviewGuidelines but it's too long to copy here. Now I don't know if I built it on koji or not, so wait till yesterday. Hopefully it will be working. btw your package should be perfect you wrote the guidelines ;-) Looks like someone broke rawhide :( http://koji.fedoraproject.org/koji/getfile?taskID=752263&name=build.log I don't know why, but it's still can't be built in koji http://koji.fedoraproject.org/koji/getfile?taskID=756612&name=build.log OK, I fixed this by adding: BuildRequires: python-devel Successful scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=757252 New SRPM: http://www.auroralinux.org/people/spot/review/new/tcl-snack-2.2.10-2.fc10.src.rpm New SPEC: http://www.auroralinux.org/people/spot/review/new/tcl-snack.spec - build in koji OK Everything pass. New Package CVS Request ==================== Package Name: tcl-snack Short Description: Sound toolkit Owners: spot Branches: F-8 F-9 devel InitialCC: ...and it's done. tcl-snack-2.2.10-2.fc8 has been submitted as an update for Fedora 8. http://admin.fedoraproject.org/updates/tcl-snack-2.2.10-2.fc8 tcl-snack-2.2.10-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/tcl-snack-2.2.10-2.fc9 Built in rawhide too. tcl-snack-2.2.10-2.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. tcl-snack-2.2.10-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. I didn't find tcl-snack component in Bugzilla. Is it normal? It seems to me that tcl-snack module doesn't work. [mkalenkov@sadki ~]$ tclsh % package require snack 2.2 couldn't load file "/usr/lib/tcl8.5/snack2.2/libsnack.so": /usr/lib/tcl8.5/snack2.2/libsnack.so: undefined symbol: _snd_pcm_mmap_hw_ptr % [mkalenkov@sadki ~]$ LANG=C; rpm -qi tcl-snack Name : tcl-snack Relocations: (not relocatable) Version : 2.2.10 Vendor: Fedora Project Release : 2.fc9 Build Date: Sat Sep 13 06:17:58 2008 Install Date: Sun Sep 21 19:43:22 2008 Build Host: x86-5.fedora.phx.redhat.com Group : System Environment/Libraries Source RPM: tcl-snack-2.2.10-2.fc9.src.rpm Size : 740007 License: GPLv2+ Signature : DSA/SHA1, Tue Sep 16 00:14:20 2008, Key ID 62aec3dc6df2196f Packager : Fedora Project URL : http://www.speech.kth.se/snack/ Summary : Sound toolkit |