Bug 454018

Summary:	Review Request: tcl-tkpng - Tcl/Tk support for PNG
Product:	[Fedora] Fedora	Reporter:	Tom "spot" Callaway <tcallawa>
Component:	Package Review	Assignee:	Deji Akingunola <dakingun>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	dakingun, fedora-package-review, moe, notting
Target Milestone:	---	Flags:	dakingun: fedora-review+ tcallawa: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	0.9-3.fc10	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-03-13 18:35:19 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	454022

Description Tom "spot" Callaway 2008-07-03 20:18:57 UTC

Spec URL: http://auroralinux.org/people/spot/review/coccinella/tcl-tkpng.spec
SRPM URL: http://auroralinux.org/people/spot/review/coccinella/tcl-tkpng-0.9-1.fc10.src.rpm
Description: 
TkPNG is an open source package that adds PNG photo image support to Tcl/Tk.
Although other extensions such as Img also add support for PNG images, this
package was designed to be lightweight, not depending on libpng nor
implementing other image formats, and suitable for inclusion in the Tk core.
Tk does not currently have native support for any image formats that allow
for alpha (partial-transparency) channels, although it does have support for
alpha blending internally.

Comment 1 Jeff Moe (jebba) 2008-10-30 22:29:36 UTC

For building on my f9-ish system it needs:
BuildRequires: zlib-devel

Comment 2 Tom "spot" Callaway 2008-10-31 13:37:55 UTC

New SRPM: http://auroralinux.org/people/spot/review/coccinella/tcl-tkpng-0.9-2.fc10.src.rpm
New SPEC: http://auroralinux.org/people/spot/review/coccinella/tcl-tkpng.spec

Scratch Build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=913492

Comment 3 Deji Akingunola 2009-03-07 03:48:34 UTC

== REVIEW ==

- package follows naming guidelines
- package follows general packaging guidelines
- package follows the tcl packaging guidlines
- licensing: TCL
- source matches upstream
  43347d3d805a5bf3ff428ed812834230  rpmbuild/SOURCES/tkpng0.9.tgz
- package compiles on F10 x86_64
- package contains no locales
- spec file uses macros consistently
- rpmlint run on packages' src.rpm and binary rpm without warnings or errors

OBSERVATION:
Package build log shows 'checking if 64bit support is requested... no' during the configure stage. While I'm not sure what the implication of that is (or might be) for the package, the 64bit support can be turned on by passing '--enable-64bit' option to the configure script.

APPROVED.

Comment 4 Tom "spot" Callaway 2009-03-12 20:38:15 UTC

New Package CVS Request
=======================
Package Name: tcl-tkpng
Short Description: Tcl/Tk support for PNG
Owners: spot
Branches: F-9 F-10 devel
InitialCC: 

... and it's done.

Comment 5 Fedora Update System 2009-03-12 21:06:52 UTC

tcl-tkpng-0.9-3.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/tcl-tkpng-0.9-3.fc9

Comment 6 Fedora Update System 2009-03-12 21:06:58 UTC

tcl-tkpng-0.9-3.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/tcl-tkpng-0.9-3.fc10

Comment 7 Fedora Update System 2009-03-13 18:35:14 UTC

tcl-tkpng-0.9-3.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2009-03-13 18:41:58 UTC

tcl-tkpng-0.9-3.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.