Bug 454174
| Summary: | Review Request: gfs-eustace-font - GFS Eustace majuscule Greek font | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nicolas Mailhot <nicolas.mailhot> |
| Component: | Package Review | Assignee: | Rahul Sundaram <sundaram> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, fonts-bugs, mvaliyav, notting, smohan |
| Target Milestone: | --- | Flags: | sundaram:
fedora-review+
a.badger: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-07-12 10:29:42 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Nicolas Mailhot
2008-07-06 00:10:39 UTC
Unofficial Review
- Rpmlint: OK
- Package name: OK
- Version: Based on a date: OK
- Specfile name: OK
- Packaging guidelines: OK
- Software license: OK
- License field in the spec file: OK
- License text from the source zip file included in %doc: OK
- The spec file is in American English: OK
- The spec file is legible: OK
- Source files the same as provided by upstream: OK
- Builds into a binary RPM; not architecture dependent, builds ok. OK
- No BuildRequires; doesn't depend on any libraries or tools besides the base
system: OK
- No locales, no need to use %find_lang: OK
- No shared libraries: OK
- Package not relocatable: OK
- Package owns all the created directories: OK
- No duplicates in %files: OK
- File permissions: OK
- Proper %clean section: OK
- Consistent macro use: OK
- No large documentation files, no -doc subpackage: OK
- Font doesn't need %doc files for operation: OK
- No header files, no -devel subpackage: OK
- No static libraries, no -static subpackage: OK
- No dependency on pkgconfig: OK
- No .la archives: OK
- Not a GUI app, no .desktop file: OK
- No other packages' files owned: OK
- rm -rf %{buildroot} is run at the beginning of %install: OK
- All filenames valid UTF-8: OK
Found few typos in the %description section in spec file.
millenium = millennium
sparce = sparse
Thanks Mintos for the review. This package is APPROVED New Package CVS Request ======================= Package Name: gfs-eustace-font Short Description: GFS Eustace majuscule Greek font Owners: nim Branches: devel only InitialCC: fonts-sig Cvsextras Commits: yes cvs done. sorry about this, I dropped a s when cut and pasting the package name, the real package is gfs-eustace-fonts New Package CVS Request ======================= Package Name: gfs-eustace-fonts Short Description: GFS Eustace majuscule Greek font Owners: nim Branches: devel only InitialCC: fonts-sig Cvsextras Commits: yes cvs done. Thanks a lot and sorry for the bother |