Bug 454469

Summary:	Review Request: php-pear-Var-Dump - rovides methods for dumping structured information about a variable
Product:	[Fedora] Fedora	Reporter:	Remi Collet <fedora>
Component:	Package Review	Assignee:	Jason Tibbitts <j>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting
Target Milestone:	---	Flags:	j: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-09-16 23:20:55 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	457590

Description Remi Collet 2008-07-08 17:30:56 UTC

Spec URL: http://remi.fedorapeople.org/php-pear-Var-Dump.spec
SRPM URL: http://remi.fedorapeople.org/php-pear-Var-Dump-1.0.3-1.fc8.src.rpm
Mock Log: http://remi.fedorapeople.org/php-pear-Var-Dump-build.log

Description: 
The Var_Dump class is a wrapper for the var_dump function.

The var_dump function displays structured information about expressions
that includes its type and value. Arrays are explored recursively with
values indented to show structure.

--
rpmlint is silent

This extension is required by new PHP_CompatInfo (1.8.0)

Comment 1 Jason Tibbitts 2008-08-20 23:09:46 UTC

* source files match upstream:
   d73b985d46a118a65d11dc1e93d6e0e7f0919237f090920478d2ab3250d17826  
   Var_Dump-1.0.3.tgz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
X missing php-pear(PEAR) dependency:
   php-pear(Var_Dump) = 1.0.3
   php-pear-Var-Dump = 1.0.3-1.fc10
  =
   /bin/sh
   /usr/bin/pear

* %check is not present; pear module tests can't be run at build time.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (pear module registration).
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

Comment 2 Remi Collet 2008-08-21 05:57:53 UTC

Spec URL: http://remi.fedorapeople.org/php-pear-Var-Dump.spec
SRPM URL: http://remi.fedorapeople.org/php-pear-Var-Dump-1.0.3-2.fc8.src.rpm

- Add missing Requires: php-pear(PEAR)

Comment 3 Jason Tibbitts 2008-08-21 12:01:02 UTC

Thanks.

APPROVED

Comment 4 Remi Collet 2008-08-22 08:14:29 UTC

Thank's for the review

New Package CVS Request
=======================
Package Name: php-pear-Var-Dump
Short Description: Methods for dumping structured information about a variable
Owners: remi
Branches: F-9 F-8 EL-5
InitialCC: 
Cvsextras Commits: yes

Comment 5 Kevin Fenzi 2008-08-23 17:56:06 UTC

cvs done.

Comment 6 Fedora Update System 2008-08-28 19:37:26 UTC

php-pear-Var-Dump-1.0.3-2.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/php-pear-Var-Dump-1.0.3-2.fc9

Comment 7 Fedora Update System 2008-08-28 19:37:57 UTC

php-pear-Var-Dump-1.0.3-2.fc8 has been submitted as an update for Fedora 8.
http://admin.fedoraproject.org/updates/php-pear-Var-Dump-1.0.3-2.fc8

Comment 8 Fedora Update System 2008-09-05 12:21:16 UTC

php-pear-Var-Dump-1.0.3-2.fc8 has been pushed to the Fedora 8 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update php-pear-Var-Dump'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F8/FEDORA-2008-7275

Comment 9 Fedora Update System 2008-09-10 06:46:46 UTC

php-pear-Var-Dump-1.0.3-2.fc8 has been pushed to the Fedora 8 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update php-pear-Var-Dump'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F8/FEDORA-2008-7275

Comment 10 Fedora Update System 2008-09-10 07:04:35 UTC

php-pear-Var-Dump-1.0.3-2.fc9 has been pushed to the Fedora 9 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update php-pear-Var-Dump'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2008-7486

Comment 11 Fedora Update System 2008-09-16 23:20:52 UTC

php-pear-Var-Dump-1.0.3-2.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2008-09-16 23:22:08 UTC

php-pear-Var-Dump-1.0.3-2.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.