Bug 454698

Summary: bugzilla.getBugActivity returns different data format in 3.2 than in 2.18
Product: [Community] Bugzilla Reporter: David Lawrence <dkl>
Component: WebServiceAssignee: Noura El hawary <nelhawar>
Status: CLOSED NEXTRELEASE QA Contact:
Severity: low Docs Contact:
Priority: low    
Version: 3.2   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-07-22 20:11:12 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 406071    
Attachments:
Description Flags
Patch to change bugzilla.getBugActivity() to return ARRAY reference (v1) nelhawar: review+

Description David Lawrence 2008-07-09 19:31:01 UTC
Description of problem:

2.18:

Bugzilla::RPC::getBugActivity returns an ARRAY reference. getBugActivity returns
the value returned from GetBugActivity in CGI.pl which is a reference to an
ARRAY containing (\@operations, $incomplete_data).

3.2:

extensions/compat_xmlrpc/code/webservice.pl getBugActivity returns a HASH reference.

($item{operations}, $item{incomplete_data}) =
Bugzilla::Bug::GetBugActivity($bug_id);

...

return \%item;

We need to change this to return the original ARRAY reference instead.

return ($item{operations}, $item{incomplete_data});

Comment 1 David Lawrence 2008-07-09 19:31:27 UTC
This breaks bugbot functionality currently.


Comment 2 David Lawrence 2008-07-09 20:12:15 UTC
Created attachment 311413 [details]
Patch to change bugzilla.getBugActivity() to return ARRAY reference (v1)

Hey Noura, I went ahead and created a simple patch to fix the return value for
bugzilla.getBugActivity to match 2.18 behaviour. Please review if you can.

Thanks
Dave

Comment 3 Noura El hawary 2008-07-10 00:36:25 UTC
Comment on attachment 311413 [details]
Patch to change bugzilla.getBugActivity() to return ARRAY reference (v1)

Hi Dave, patch looks good and works nicely, I committed few things to
webservice.pl so this patch might need to be applied manually. 

Noura

Comment 4 David Lawrence 2008-07-10 03:53:40 UTC
Thanks Noura. Checked in.

Comment 5 David Lawrence 2008-07-22 20:11:12 UTC
The changes have been pushed to partner-bugzilla.redhat.com and/or have been
recorded in the Bugzilla migration pages on the Bugzilla 3 upgrade Wiki.

Closing as NEXTRELEASE.
Dave