Bug 454940
Summary: | Review Request: rcssbase - Base libraries for Robocup Soccer Server (2D) | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Hedayat Vatankhah <hedayatv> |
Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | rawhide | CC: | fedora-package-review, notting |
Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-08-08 05:15:21 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Hedayat Vatankhah
2008-07-10 22:06:35 UTC
A self review!: - rpmlint output: rpmlint complains about absence of docs in the -devel sub-package. I cannot find any relevant files to put as doc files for -devel package - package name is equal to the upstream name - spec file name is correct - the package is under LGPLv2 or later - License field matches with the actual license - License file is included in the package docs - the spec file is (hopefully!) in American English - the spec file is legible (I think) - source code matches upstream (I can't compare since I've only one package which is what I downloaded from Internet and is included in the SRPM. Anyway the md5sum output is: 13cc197d352744ff03b13360f8852e90 rcssbase-12.1.0.tar.gz - I am able to build the package in Fedora 9 on my system (32bit) - I'm not aware of any specific architectures which the package can't be built in - It seems that Build Requires section is correct. I can build the package using mock - No locale specific stuff in this package - Runs ldconfig in %post & %postun - Package is not relocatable - The package owns its directories - Doesn't contain duplicate files - file permissions should be OK - contains a %clean section - have consistent use of macros - header files are in -devel sub-pacakge. No -static package needed. - -devel package requires the base package - doesn't contain any .la files - Not a GUI application - calls rm -rf %{buildroot} in %install - filenames are in UTF-8 Should Items: - The package builds in python > - The package builds in python
Sorry, I wanted to say that the package can be built using mock!
For 12.1.0-1: * License: ------------------------------------------------------------ rcssbase/conf/buildertest.cpp GPLv2+ rcssbase/lib/factorytest/factorytest.cpp GPLv2+ rcssbase/lib/loadertest/ GPLv2+ rcssbase/net/addrtest/addrtest.cpp GPLv2+ rcssbase/net/iosocketstreamtest/iosocketstreamtest.cpp GPLv2+ rcssbase/net/tcpsockettest/tcpsockettest.cpp GPLv2+ rcssbase/net/udpsockettest/udpsockettest.cpp GPLv2+ ------------------------------------------------------------ - %_bindir/rcssmodtest is licensed under GPLv2+. So please modify license tag like: ------------------------------------------------------------ Group: Development/Libraries # %%{_bindir}/rcssmodtest is licensed under GPLv2+, others # are under LGPLv2+ License: LGPLv2+ and GPLv2+ URL: http://sourceforge.net/projects/sserver/ ... ... %package devel Summary: Header files and libraries for %{name} Group: Development/Libraries License: LGPLv2+ ... ------------------------------------------------------------ * build issue - build error: Does not build on x86_64: http://koji.fedoraproject.org/koji/taskinfo?taskID=709246 m4/ax_boost_base.m4 cannot deal with /usr/lib64 correctly. The following can be a workaround: ------------------------------------------------------------ %prep %setup -q %patch0 -p1 -b .gcc43fix %patch1 -p1 -b .libfix find -name "*.cpp" -exec chmod a-x {} \; find -name "*.hpp" -exec chmod a-x {} \; sed -i.lib \ -e 's|\$ac_boost_path/lib|\$libdir|' \ -e 's|$ac_boost_path_tmp/lib|\$libdir|' \ m4/ax_boost_base.m4 ------------------------------------------------------------ - Undesired autotools call build.log shows: ------------------------------------------------------------ configure: creating ./config.status config.status: creating Makefile config.status: creating config.h config.status: executing depfiles commands + sed -i -e 's! -shared ! -Wl,--as-needed\0!g' libtool + make -j4 cd . && /bin/sh /builddir/build/BUILD/rcssbase-12.1.0/missing --run autoheader rm -f stamp-h1 touch config.h.in cd . && /bin/sh ./config.status config.h config.status: creating config.h config.status: config.h is unchanged make all-recursive make[1]: Entering directory `/builddir/build/BUILD/rcssbase-12.1.0' ------------------------------------------------------------ Here autoheader is called after configure is finished, which is not desired. Usually this means timestamps on some autotool related files are not right. Using "autoreconf -f -i" instead of "autotool -i" fixes this issue - And please move autoreconf call from %build to at the last of %prep. * configure option - build.log shows: ------------------------------------------------------------ 289 checking for deflate in -lz... 290 no 449 checking ltdl.h usability... 450 no 451 checking ltdl.h presence... 452 no 453 checking for ltdl.h... no 454 checking whether to use included libltdl... ------------------------------------------------------------ However both zlib-devel and libtool-ltdl-devel are available so please add these to BuildRequires. * Timestamps - For this package CPPROG="cp -p" is not needed as this package does not use install-sh. * rpath - rpath check does not pass on 64 bit (currently koji down and I cannot post the build result done on koji build The following can be a workaround: ------------------------------------------------------------ autoreconf -fi # Fix rpath sed -i.rpath -e '/sys_lib_search_path_spec/s| /usr/lib| /lib64 /usr/lib64 /usr/lib|' \ configure ------------------------------------------------------------ (again please move autoconf call to %prep) (In reply to comment #3) > For 12.1.0-1: > > * rpath > - rpath check does not pass on 64 bit (currently koji down and I cannot > post the build result done on koji build This is: http://koji.fedoraproject.org/koji/taskinfo?taskID=710377 ping? Hi, I'm so sorry about it! I didn't expect that I could finally participate in RoboCup 2008 competitions but it happened! So, I couldn't correct the problems and build a newer package. Sorry for being quiet during this period. I'm still in china but we will return back soon. I didn't find enough time to talk about it here. sorry again. OK, Sorry again. These are the new files: Spec: http://www.assembla.com/spaces/hedayat/documents/dZnKuQtSOr3An4ab7jnrAJ/download/rcssbase.spec SRPM: http://www.assembla.com/spaces/hedayat/documents/c03QwgxHCr3ymXab7jnrAJ/download/rcssbase-12.1.0-2.fc9.src.rpm Looks okay, however current newest version seems 12.1.1. Would you upgrade? OK, I will. Removing NEEDSPONSOR (bug 450409) Updated package: SPEC:http://www.assembla.com/spaces/hedayat/documents/dZnKuQtSOr3An4ab7jnrAJ/download/rcssbase.spec SRPM: http://www.assembla.com/spaces/hedayat/documents/c-GdeKyzqr3yzEab7jnrAJ/download/rcssbase-12.1.1-1.fc9.src.rpm Good. ----------------------------------------------------------------- This package (rcssbase) is APPROVED by mtasaka ----------------------------------------------------------------- Thanks. New Package CVS Request ======================= Package Name: rcssbase Short Description: Base libraries for Robocup Soccer Server (2D) Owners: hedayat Branches: F-8 F-9 Cvsextras Commits: yes cvs done. rcssbase-12.1.1-1.fc9 has been submitted as an update for Fedora 9 rcssbase-12.1.1-1.fc8 has been submitted as an update for Fedora 8 Closing. rcssbase-12.1.1-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. rcssbase-12.1.1-1.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. |