Bug 454967

I would recommend following the standard template specified at 

http://fedoraproject.org/wiki/Annotated_fonts_spec_template

It would ease the review process quite a bit if you follow that which is always
a good thing.

Modified to more closely follow fedora's policies, and per my experience with
thibault-fonts.
Spec URL: http://www.oslb.net/fonts/darkgarden/darkgarden-fonts.spec
SRPM URL: http://www.oslb.net/fonts/darkgarden/darkgarden-fonts-1.1-1.fc9.src.rpm

Mock built for FC7, FC8, and FC9
RPMS:
FC9: http://www.oslb.net/fonts/darkgarden/darkgarden-fonts-1.1-1.fc9.noarch.rpm
FC8: http://www.oslb.net/fonts/darkgarden/darkgarden-fonts-1.1-1.fc8.noarch.rpm
FC7: http://www.oslb.net/fonts/darkgarden/darkgarden-fonts-1.1-1.fc7.noarch.rpm

SRPMS:
FC9: http://www.oslb.net/fonts/darkgarden/darkgarden-fonts-1.1-1.fc9.src.rpm
FC8: http://www.oslb.net/fonts/darkgarden/darkgarden-fonts-1.1-1.fc8.src.rpm
FC7: http://www.oslb.net/fonts/darkgarden/darkgarden-fonts-1.1-1.fc7.src.rpm

Lyos Gemini Norezel

1.) This comment is useless:

# for example: install -pm 644 *.ttf $RPM_BUILD_ROOT%{fontdir}

2.) You mix %{buildroot} and $RPM_BUILD_ROOT

See http://fedoraproject.org/wiki/Packaging/Guidelines#UsingBuildRootOptFlags

3.) Use %setup macro instead of the following:

%prep
unzip %{SOURCE0}

%build
cd darkgarden-1.1

And after that is done, please do not move the files around in %build, there's
no need to.

4.) Another useless comment, please remove it

%changelog
#DarkGarden
* Mon Jul 21 2008 Lyos Gemini Norezel <Lyos.GeminiNorezel> 1.1-1

Also, please use a more descriptive %description. One you used in this request
should be fine.

Spec and src updated:
Spec URL: http://www.oslb.net/fonts/darkgarden/darkgarden-fonts.spec
SRPM URL: http://www.oslb.net/fonts/darkgarden/darkgarden-fonts-1.1-1.fc9.src.rpm

Lyos Gemini Norezel

Mock Build files and logs:

SRPMS:
FC7: http://www.oslb.net/fonts/darkgarden/darkgarden-fonts-1.1-1.fc7.src.rpm
FC8: http://www.oslb.net/fonts/darkgarden/darkgarden-fonts-1.1-1.fc8.src.rpm
FC9: http://www.oslb.net/fonts/darkgarden/darkgarden-fonts-1.1-1.fc9.src.rpm

RPMS:
FC7: http://www.oslb.net/fonts/darkgarden/darkgarden-fonts-1.1-1.fc7.noarch.rpm
FC8: http://www.oslb.net/fonts/darkgarden/darkgarden-fonts-1.1-1.fc8.noarch.rpm
FC9: http://www.oslb.net/fonts/darkgarden/darkgarden-fonts-1.1-1.fc9.noarch.rpm

Logs:
FC7: http://www.oslb.net/fonts/darkgarden/build-fc7.log
FC8: http://www.oslb.net/fonts/darkgarden/build-fc8.log
FC9: http://www.oslb.net/fonts/darkgarden/build-fc9.log

Thanks for the package -- it seems very well. Filelists, provides and requires
are sane; SPEC file is clean and legible.

APPROVED

Note: The src.rpms linked to above are either outdated or truncated, I tested
the the new SPEC file with source from older SRPM. Please ensure that you use
the right SPEC file when importing. Thanks!

Packager seems to be responsive to criticism and has updated packages to meet
guidelines.  I've sponsored him.

New Package CVS Request
=======================
Package Name: thibault-fonts
Short Description: A collection of fonts from thibault.org, including Isabella,
Essays1743, Rockets, and StayPuft.
Owners: lyosnorezel
Branches: F-8 F-9
InitialCC: lyosnorezel
Cvsextras Commits: yes

New Package CVS Request
=======================
Package Name: darkgarden-fonts
Short Description: Dark Garden is a decorative outline font of unusual shape.
Owners: lyosnorezel
Branches: F-8 F-9
InitialCC: lyosnorezel
Cvsextras Commits: yes

cvs done.

darkgarden-fonts-1.1-1.fc8 has been submitted as an update for Fedora 8

darkgarden-fonts-1.1-1.fc9 has been submitted as an update for Fedora 9

darkgarden-fonts-1.1-1.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

darkgarden-fonts-1.1-1.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.