Bug 455069
| Summary: | Review Request: Xpad - Sticky notepad for GTK+2 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Stefan Posdzich <cheekyboinc> |
| Component: | Package Review | Assignee: | Thomas Moschny <thomas.moschny> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, peter |
| Target Milestone: | --- | Flags: | thomas.moschny:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-07-19 18:16:05 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Stefan Posdzich
2008-07-11 20:06:22 UTC
*** Bug 193499 has been marked as a duplicate of this bug. *** [x] = ok, [!] = not ok, [-] = not applicable
[x] package meets naming guidelines
[x] specfile is encoded in ascii or utf-8
[x] specfile matches base package name
[x] specfile uses macros consistently
[x] specfile is written cleanly
[x] specfile is written in AE
[x] changelog is present and has correct format
[x] license matches actual license
[x] license is open source-compatible
[x] license text is included in package
[x] source tag has correct url
[x] source files match upstream
md5sum: 1e12e6aec8f03a656eb6427ba22c38d3
[x] latest version is packaged
[x] summary is concise
[x] dist tag is present
[x] buildroot is correct
[x] buildroot is prepped
[x] %clean is present
[!] proper build requirements
libICE-devel is already required by libSM-devel
[!] proper requirements
require hicolor-icon-theme (owns /usr/share/icons/hicolor/scalable/apps)
[x] uses %{?_smp_mflags}
[x] uses %{optflags}
[x] doesn't use %makeinstall
[x] package builds at least on one architecture
tested on: f9/x86_64
[x] packages installs and runs at least on one architecture
tested on: f9/x86_64
[x] rpmlint is quiet
[x] final provides/requires look sane
[-] ldconfig called in %post and %postun if required
[x] code, not content
[x] file permissions are appropriate
[x] debuginfo package looks usable
[-] config files marked as %config(noreplace)
[!] owns all the directories it creates
see above
[-] static libraries in -devel subpackage
[-] header files in -devel subpackage
[-] development .so files in -devel subpackage
[-] pkgconfig files in -devel subpackage, requires pkgconfig
[x] no .la files
[x] doesn't need a -docs subpackage
[!] relevant docs are included
please add NEWS, THANKS and TODO
[x] doc files are not needed at runtime
[x] provides a .desktop file, build-requires desktop-file-utils
[x] uses %find_lang, build-requires gettext
minor issue:
replace "%{_mandir}/man1/%{name}.1.*" with "%{_mandir}/man1/%{name}.1*"
Oh, and one blocker: Please fix the %description (the specfile in the src.rpm is different from that in the link you gave). Spec: http://cheekyboinc.spielen-unter-linux.de/xpad.spec SRPM: http://cheekyboinc.spielen-unter-linux.de/xpad-2.14-2.fc9.src.rpm Changelog: - description fixed - Add doc NEWS, THANKS and TODO - Add Requires: hicolor-icon-theme - Remove BuildRequires: libICE-devel Looks good. APPROVED. New Package CVS Request ======================= Package Name: xpad Short Description: Sticky notepad for GTK+2 Owners: cheekyboinc Branches: F-8 F-9 InitialCC: Cvsextras Commits: yes cvs done. xpad-2.14-2.fc8 has been submitted as an update for Fedora 8 xpad-2.14-2.fc9 has been submitted as an update for Fedora 9 xpad-2.14-2.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. xpad-2.14-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. |