Bug 455071

Summary: Review Request: xfce4-mpc-plugin - MPD client for the Xfce panel
Product: [Fedora] Fedora Reporter: Christoph Wickert <cwickert>
Component: Package ReviewAssignee: Kevin Fenzi <kevin>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, kevin, nonamedotc, notting
Target Milestone: ---Flags: kevin: fedora‑review+
limburgher: fedora‑cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-07-14 05:52:10 EDT Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Description Christoph Wickert 2008-07-11 16:17:18 EDT
Spec URL: http://cwickert.fedorapeople.org/review/xfce4-mpc-plugin.spec
SRPM URL: http://cwickert.fedorapeople.org/review/xfce4-mpc-plugin-0.3.3-1.fc10.src.rpm
Description: A simple client plugin for MPD, the Music Player Daemon.
Comment 1 Kevin Fenzi 2008-07-13 00:03:55 EDT
I would be happy to review this. Look for a full review in a bit. 
Comment 2 Kevin Fenzi 2008-07-13 00:07:40 EDT
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
See below - License (BSD)
See below - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
b4f7f67589f34f77973a51dd5069712d  xfce4-mpc-plugin-0.3.3.tar.gz
b4f7f67589f34f77973a51dd5069712d  xfce4-mpc-plugin-0.3.3.tar.gz.orig
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - No rpmlint output.
OK - final provides and requires are sane:

SHOULD Items:

OK - Should build in mock.
OK - Should build on all supported archs
OK - Should have sane scriptlets.
OK - Should have dist tag
OK - Should package latest version

Issues:

1. Is the License tag here really BSD?
I think it should be "ISC"
http://www.isc.org/index.pl?/sw/dhcp/dhcp-copyright.php
(well, it's ISC style)

Comment 3 Christoph Wickert 2008-07-13 09:49:14 EDT
Yes, it's ISC but not BSD. Can I change that after import or do you want me to
do it now?
Comment 4 Kevin Fenzi 2008-07-13 15:27:45 EDT
When you import is fine with me. 

I don't see any other issues, so this is APPROVED.
Comment 5 Christoph Wickert 2008-07-13 16:52:01 EDT
New Package CVS Request
=======================
Package Name: xfce4-mpc-plugin
Short Description: MPD client for the Xfce panel
Owners: cwickert
Branches: F-8 F-9
InitialCC:
Cvsextras Commits: yes
Comment 6 Kevin Fenzi 2008-07-13 23:03:19 EDT
cvs done.
Comment 7 Fedora Update System 2008-07-14 05:46:34 EDT
xfce4-mpc-plugin-0.3.3-1.fc9 has been submitted as an update for Fedora 9
Comment 8 Fedora Update System 2008-07-14 05:48:11 EDT
xfce4-mpc-plugin-0.3.3-1.fc8 has been submitted as an update for Fedora 8
Comment 9 Christoph Wickert 2008-07-14 05:52:10 EDT
Thanks for the review, Kevin. If you want to do another bug #455083 is still
left. ;)
Comment 10 Fedora Update System 2008-07-15 08:14:15 EDT
xfce4-mpc-plugin-0.3.3-1.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 11 Fedora Update System 2008-07-15 08:16:45 EDT
xfce4-mpc-plugin-0.3.3-1.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 12 Mukundan Ragavan 2015-03-28 22:15:03 EDT
Package Change Request
======================
Package Name: xfce4-mpc-plugin
New Branches: epel7
Owners: cwickert nonamedotc
InitialCC: nonamedotc
Comment 13 Gwyn Ciesla 2015-03-28 22:40:50 EDT
Git done (by process-git-requests).