Bug 455284
Summary: | olive-gtk gives KeyError when Using Log Button | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Rehan Khan <rehan.khan> |
Component: | bzr-gtk | Assignee: | Toshio Ernie Kuratomi <a.badger> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | 8 | CC: | a.badger, shahms |
Target Milestone: | --- | Keywords: | Reopened |
Target Release: | --- | ||
Hardware: | i386 | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-11-19 22:36:39 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Rehan Khan
2008-07-14 17:15:14 UTC
Olive is now Provided and Obsoleted by the bzr-gtk package so attempting to force both olive-0.91 and the latest bzr-gtk-0.94+ in together is going to only yield errors. If you are unable to run olive-gtk when you have bzr-gtk-0.94 installed and do not have an olive package installed then there could be problems. ah, ok. The bug search came up with this : https://bugzilla.redhat.com/show_bug.cgi?id=237023 so I thought they should be different packages. I wasn't trying to force them to co-exist, I was trying to resolve the issue where if I browse to a bzr directory and click on log the log dialog does not display any data. If I run olive-gtk from a console, clicking on log drops this traceback on the console: Traceback (most recent call last): File "/usr/lib/python2.5/site-packages/bzrlib/plugins/gtk/branchview/treeview.py", line 292, in populate self.mainline_only) File "/usr/lib/python2.5/site-packages/bzrlib/plugins/gtk/branchview/linegraph.py", line 62, in linegraph for ghost_child in graph_children[ghost]: KeyError: '-' This is with bzr-gtk 0.94 with no separate olive package installed. The olive 0.91 package was able to to populate the log dialog with the history of revisions. Perhaps I need to reboot to properly get rid of the old olive package. I will post back the next time I reboot. Not sure if a closed bug will notify you so I will reopen it. Thanks Fix committed. Waiting for builds to finish. bzr-gtk-0.94.0-4.fc9 has been submitted as an update for Fedora 9 bzr-gtk-0.94.0-4.fc8 has been submitted as an update for Fedora 8 If you'd like to try out this fix before it goes out to the world, you can download it from the build link on this page in the update system: https://admin.fedoraproject.org/updates/F9/pending/bzr-gtk-0.94.0-4.fc9 Thanks Toshio the log function works really well. Actually Olive is much more responsive (snappy?) from a ui perspective, log is pretty much instantaneous when before it took a couple of seconds. I seem to have stumbled on a couple of other bugs: 1) If I do a <menu> -> branch -> Get and I fill in lp:smart (for example) clicking the open folder button next to the revision box produces this traceback: Traceback (most recent call last): File "/usr/lib/python2.5/site-packages/bzrlib/plugins/gtk/branchview/treeview.py", line 292, in populate self.mainline_only) File "/usr/lib/python2.5/site-packages/bzrlib/plugins/gtk/branchview/linegraph.py", line 50, in linegraph for (revid, parent_revids) in graph.iter_ancestry(start_revs): File "/usr/lib/python2.5/site-packages/bzrlib/graph.py", line 438, in iter_ancestry pending = set(revision_ids) TypeError: list objects are unhashable This also happens if I do a checkout. Getting the branch or checkout then produces a float division error dialog with no traceback on the console leaving a tiny progress window which can only be closed from right clicking the window in the panel and selecting close. 2) If I have an existing branch and do a pull either I get the same float division error as above or it says pull ok but leaves the same tiny progress bar window. cheers #1 is a bug that's at least partially dependent on the patch introduced here. I'm not seeing where the bad value is being introduced in the first place, though. Have to search further. #2 seems unrelated. It's probably best to report upstream to get someone working on the issue. You can open a bug here to track upstream's progress and I can backport when upstream has fixed it: https://bugs.launchpad.net/bzr-gtk bzr-gtk-0.94.0-4.fc8 has been pushed to the Fedora 8 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update bzr-gtk'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F8/FEDORA-2008-6493 I posted this upstream (https://bugs.launchpad.net/bugs/249253). It appears that these bugs are fixed in trunk/0.95. Cheers Thanks. I've looked at the diff between trunk and 0.94.0. Unfortunately, it looks like the progressbar changes are pretty far reaching and invasive. So I don't think I'll be solving the problem with the tiny progress window. The good news is that I discovered that upstream now has a different fix for the log error in trunk. With that fix applied all the tracebacks go away. So the problems with olive will just be cosmetic, not missing functionality. Making a new build now. bzr-gtk-0.94.0-5.fc8 has been submitted as an update for Fedora 8 bzr-gtk-0.94.0-5.fc9 has been submitted as an update for Fedora 9 bzr-gtk-0.94.0-5.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. bzr-gtk-0.94.0-5.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. |