Bug 455358
Summary: | Review Request: xslthl - XSLT Syntax Highlighting for saxon and xalan | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jeff Fearn 🐞 <jfearn> |
Component: | Package Review | Assignee: | Nigel Jones <dev> |
Status: | CLOSED DEFERRED | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting, petersen |
Target Milestone: | --- | Flags: | dev:
fedora-review?
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-01-05 04:51:45 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Jeff Fearn 🐞
2008-07-15 02:15:29 UTC
Will tackle this shortly. Hmmm so I should have taken a sneak peak at the spec file before, here are some initial concerns: - The spec file is licensed - Not good, might be an idea to rewrite from scratch. - Epoch: is not needed as it's zero - Another 'bad thing' in Fedora - We don't require that packages have Requires for /bin/rm and /bin/ln, you can safely assume that these exist - According to https://fedoraproject.org/wiki/Packaging/Java -- The jpackage-utils dependency need to have a firm dependency as well (not just a post/postun) -- You don't need epochs for dependencies when they are 0, It builds so your mostly there, but I'd sooner it be closer to the guidelines before I give it the big tick (hopefully any furthur changes would be minor enough you can just fix them upon import :)) I retrieved the latest source from the upstream developer and created a new spec file from scratch. Spec URL: http://jfearn.fedorapeople.org/files/xslthl.spec SRPM URL: http://jfearn.fedorapeople.org/files/xslthl-2.0.0.0.fc9.src.rpm (In reply to comment #3) > I retrieved the latest source from the upstream developer and created a new > spec file from scratch. > > Spec URL: http://jfearn.fedorapeople.org/files/xslthl.spec > SRPM URL: http://jfearn.fedorapeople.org/files/xslthl-2.0.0.0.fc9.src.rpm Per https://fedoraproject.org/wiki/Packaging/Java#BuildRequires_and_Requires you need: BR: java-devel >= 1:1.6.0 Depend: java >= 1:1.6.0 Seems to build with that, I'll finish the review on the basis that this has been done and we'll go from there. http://jfearn.fedorapeople.org/files/xslthl.spec updated as requested. Sweet http://jfearn.fedorapeople.org/files/xslthl.spec http://jfearn.fedorapeople.org/files/xslthl-2.0.0-1.fc9.src.rpm Request withdrawn. |