Bug 456009

Summary: Review Request: python-jinja2 - General purpose template engine
Product: [Fedora] Fedora Reporter: Thomas Moschny <thomas.moschny>
Component: Package ReviewAssignee: Jochen Schmitt <jochen>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, metherid, notting
Target Milestone: ---Flags: jochen: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-08-20 21:01:07 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Thomas Moschny 2008-07-20 14:37:45 UTC
Spec URL: http://thm.fedorapeople.org/python-jinja2.spec
SRPM URL: http://thm.fedorapeople.org/python-jinja2-2.0-1.fc9.src.rpm

Jinja2 is a template engine written in pure Python.  It provides a
Django inspired non-XML syntax but supports inline expressions and an
optional sandboxed environment.

If you have any exposure to other text-based template languages, such
as Smarty or Django, you should feel right at home with Jinja2. It's
both designer and developer friendly by sticking to Python's
principles and adding functionality useful for templating


Making a new package for version 2 of Jinja as it is not completely backwards compatible to version 1.

Comment 1 Jochen Schmitt 2008-07-21 19:47:17 UTC
+ Local build works fine
+ Rpmlint is quite on source rpm.
+ Rpmlint is quite on binary rpm.
+ Rpmlint is quite on debuginfo rpm.
+ License is an open source license.
+ Package contains verbatin copy of the licens.
+ Usage of rpm macro is consitant.
+ Package doesn't own files or directories from other packeges
+ Mock build works fine.
+ License text seems ok.
+ Tar ball matches with upstrem
  (md5sum: 19fe3ee10ee94a6003c53374112f2403)
+ Local install works fine.
+ Local uninstall works fine.

*** APPROVED ***

Comment 2 Jochen Schmitt 2008-07-21 19:50:51 UTC
Sorry, In the last moment I have found one complaint:

In the package you use %{buildroot} and $RPM_BUILD_ROOT.

If you may fix this monor isue, you are APPROVED.

Comment 3 Thomas Moschny 2008-07-22 16:06:22 UTC
Thanks for reviewing!

New Package CVS Request
Package Name: python-jinja2
Short Description: General purpose template engine
Owners: thm
Branches: F-8 F-9
InitialCC: none
Cvsextras Commits: yes

Comment 4 Kevin Fenzi 2008-07-23 03:01:41 UTC
cvs done.

Comment 5 Fedora Update System 2008-07-24 08:24:48 UTC
python-jinja2-2.0-2.fc9 has been submitted as an update for Fedora 9

Comment 6 Fedora Update System 2008-07-24 08:26:24 UTC
python-jinja2-2.0-2.fc8 has been submitted as an update for Fedora 8

Comment 7 Fedora Update System 2008-08-12 18:24:43 UTC
python-jinja2-2.0-2.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2008-08-12 18:25:32 UTC
python-jinja2-2.0-2.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 Thomas Moschny 2008-08-20 21:01:07 UTC

Comment 10 Rahul Sundaram 2011-07-12 12:44:41 UTC
Package Change Request
Package Name: python-jinja2
New Branches: el6
Owners: sundaram pjp

Comment 11 Gwyn Ciesla 2011-07-13 03:13:20 UTC
Git done (by process-git-requests).

Comment 12 Thomas Moschny 2011-07-13 09:58:55 UTC

- python-jinja2  is part of RHEL6
- it would have been nice to ask me beforehand as I'm already maintaining it in EPEL5.

Comment 13 Rahul Sundaram 2011-07-13 10:40:55 UTC
I must have overlooked that.  I will get the branch removed