Bug 456084
| Summary: | Review Request: gfs-garaldus-fonts - GFS Garaldus majuscule Greek font | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nicolas Mailhot <nicolas.mailhot> |
| Component: | Package Review | Assignee: | Rahul Sundaram <sundaram> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, fonts-bugs, notting, smohan |
| Target Milestone: | --- | Flags: | sundaram:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-07-22 19:50:34 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Nicolas Mailhot
2008-07-21 13:43:58 UTC
rpmlint has this to say: gfs-garaldus-fonts.src: E: no-spec-file OK | MUST: The spec file name must match the base package… OK | MUST: The package must meet the Packaging Guidelines… OK | MUST: The package must be licensed with a Fedora approved… OK | MUST: The License field in the package spec file must… OK | MUST: Packaged detached license and specified in %doc OK | MUST: The spec file for the package MUST be legible. OK | MUST: The package must successfully compile and build… OK | MUST: successfully compile, build OK | MUST: All build dependencies must be listed… OK | MUST: A package must own all directories that it creates OK | MUST: A package must not contain any duplicate files OK | MUST: Permissions on files must be set properly. OK | MUST: Each package must have a %clean section OK | MUST: Each package must consistently use macros OK | MUST: The package must contain code, or permissible OK | MUST: Packages must not own files or directories already OK | MUST: At the beginning of %install, each package MUST… OK | MUST: All filenames in rpm packages must be valid UTF-8. OK | SHOULD: If the source package does not include license OK | SHOULD: The description and summary section … translations… OK | SHOULD: The package builds in mock OK | SHOULD: The package builds on all supported architectures OK | SHOULD: The reviewer should test that the package… OK | SHOULD: If scriptlets are used, those scriptlets must be sane… Fix the odd rpmlint warning and you are APPROVED I guess I pay for the fact rpmlint is broken in rawhide by the new rpm, so I can't run it. However I do know what that warning means (font spec filename ≠ rpm filename) so I'll fix it before import Thanks you for the lighting-fast review! New Package CVS Request ======================= Package Name: gfs-garaldus-fonts Short Description: GFS Garaldus majuscule Greek font Owners: nim Branches: devel only InitialCC: fonts-sig Cvsextras Commits: yes cvs done. Thanks! |