Bug 456150
Summary: | Review Request: slapi-nis - NIS Server and Schema Compatibility plugins for Fedora DS | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Nalin Dahyabhai <nalin> |
Component: | Package Review | Assignee: | Rob Crittenden <rcritten> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, lemenkov, notting |
Target Milestone: | --- | Flags: | rcritten:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-02-16 18:32:43 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Nalin Dahyabhai
2008-07-21 18:55:47 UTC
Review: + package builds in mock (F8 x86_64). - rpmlint reports the following errors and warnings: rpmlint reports 1 error and 1 warning: slapi-nis.x86_64: I: checking slapi-nis.x86_64: E: summary-too-long NIS Server and Schema Compatibility plugins for Fedora and Red Hat Directory Server The "Summary:" must not exceed 79 characters. slapi-nis.x86_64: W: incoherent-version-in-changelog 0.2-1 0.6-1.fc8 The last entry in %changelog contains a version identifier that is not coherent with the epoch:version-release tuple of the package. 1 packages and 0 specfiles checked; 1 errors, 1 warnings. + source files match upstream. e9bc790e51187f3afa13dc2611e5d93a python-kerberos-1.0.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + License is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears consistent. + Compiler flags are honored correctly. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does own the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. + Removes the buildroot in %install I haven't tested that the plugin doesn't cause FDS to core yet. (In reply to comment #1) > Review: > + package builds in mock (F8 x86_64). > - rpmlint reports the following errors and warnings: > rpmlint reports 1 error and 1 warning: > > slapi-nis.x86_64: I: checking > slapi-nis.x86_64: E: summary-too-long NIS Server and Schema Compatibility > plugins for Fedora and Red Hat Directory Server > The "Summary:" must not exceed 79 characters. Shortened. > slapi-nis.x86_64: W: incoherent-version-in-changelog 0.2-1 0.6-1.fc8 > The last entry in %changelog contains a version identifier that is not > coherent with the epoch:version-release tuple of the package. 0.6-1 is as close as I can get, what with the dist tag and all. The .spec file has been updated, not spinning a new tarball because it's built from a git tag. Thanks! + rpmlint is silent I also setup a FDS instance, configured and loaded the plugin, added a user in the right mapping and NIS: # ypcat -k -d example.com -h localhost passwd tuser tuser:*:1160:500:Test User:/home/tuser:/bin/sh APPROVED New Package CVS Request ======================= Package Name: slapi-nis Short Description: NIS Server and Schema Compatibility plugins for Directory Server Owners: nalin Branches: F-8 F-9 InitialCC: Cvsextras Commits: yes cvs done. Don't forget to close tickets when package was pushed to main repository. |