Bug 456225

RHTS job information that lead to this BZ being filed:

http://rhts.redhat.com/cgi-bin/rhts/jobs.cgi?id=25597

P.

I would proceed with making the change, it is a known problem and we should
address the issue to keep x86/x86_64 in sync.  I am not concerned with the clock
source selection code path, it should not be affected.

I'll take a look at the code this week.  This is just some sort of
Makefile/Kconfig breakage.

P.

Well ... I figured out why this isn't building on x86_64.  It's because
CONFIG_GENERIC_TIME isn't defined.  Even with that, there are other functions
that are undefined on x86_64 (ex. mark_tsc_unstable() ) that are defined within
i386.

I'll see how big of a backport is required -- hopefully, not much.

P.

There are a lot of conflicts between the the arch/x86_64 code and the
clocksource code -- it will take significant hacks to make this compile, and
even then, x86_64 only has code for the acpi_pm.

After fixing the issue with mark_tsc_unstable() we end up with

kernel/built-in.o: In function `do_gettimeofday':
/usr/src/redhat/BUILD/kernel-2.6.18/linux-2.6.18.x86_64/kernel/timer.c:994:
multiple definition of `do_gettimeofday'
arch/x86_64/kernel/built-in.o:/usr/src/redhat/BUILD/kernel-2.6.18/linux-2.6.18.x86_64/arch/x86_64/kernel/time.c:137:
first defined here
ld: Warning: size of symbol `do_gettimeofday' changed from 143 in
arch/x86_64/kernel/built-in.o to 157 in kernel/built-in.o
kernel/built-in.o: In function `do_settimeofday':
/usr/src/redhat/BUILD/kernel-2.6.18/linux-2.6.18.x86_64/kernel/timer.c:1010:
multiple definition of `do_settimeofday'
arch/x86_64/kernel/built-in.o:/usr/src/redhat/BUILD/kernel-2.6.18/linux-2.6.18.x86_64/arch/x86_64/kernel/time.c:168:
first defined here
ld: Warning: size of symbol `do_settimeofday' changed from 215 in
arch/x86_64/kernel/built-in.o to 251 in kernel/built-in.o
drivers/built-in.o:(.data.read_mostly+0x28): multiple definition of `pmtmr_ioport'
arch/x86_64/kernel/built-in.o:(.data.read_mostly+0x5174): first defined here
make: *** [.tmp_vmlinux1] Error 

I suggest changing this to WONTFIX.  Unless we're willing to do a large backport
of code that has no purpose in RHEL, I can't see the benefit to fix the output
of that one /sys file.

Thoughts/concerns?

P.