Bug 456303

I would be happy to review this package. Look for the review today late.

Package did not built for me -- BuildRequires needs zlib-devel
I compiled it after adding Buildrequires and here is review:

Required

[x] rpmlint output 
[x] package naming
[x] spec file name
[x] packaging guidlines 
[x] license approved
[x] license field in spec
[x] license file
[x] language used in spec file -- American English
[x] spec file -- legible
[!] Source0 link did not worked for me, though I know this link should work for 
all projects on sourceforge. 
     I downloaded using http://bcrypt.sourceforge.net/bcrypt-1.1.tar.gz and 
assume you did the same. 
     May you please confirm.
     md5sum
     upstream - 8ce2873836ccd433329c8df0e37e298c
     package source - 8ce2873836ccd433329c8df0e37e298c
[!] package build in mock
[!] BuildRequires -- zlib-devel missing
[NA] locales
[NA] shared library files
[NA] relocatable
[x] owns directory it creates in %{doc}
[x] duplicate files not present
[x] %clean & %install section contain rm -rf $RPM_BUILD_ROOT
[x] permissible package content 
[x] file encoding - utf-8
[x] file permissions -- correct
[NA] Header files and static libraries 
[x] package has no dependency on files in %doc
[NA] GUI

Optional
[NA] Query upstream regarding license
[NA] Translation for description and summary available
[!] Package build in mock for all architectures -- failed
     but after putting in BuildRequires build correctly
[NA] scripts used
[x] No dependencies outside FHS guidelines
[NA] subpackages
[NA] .pc files 

Optional suggestions (you may not like to consider them):
a. BuiltRoot tag %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) 
is preferred
b. using macros consistently e.g URL can be http://%{name}.sourceforge.net/

Key NA = N/A, x = Check, ! = Problem, ? = Not evaluated

Fixed BR. The regular url for sf.net works fine for me. Fixed macro. Left
BuildRoot alone since that is technically obsolete anyway. 

http://sundaram.fedorapeople.org/packages/bcrypt.spec
http://sundaram.fedorapeople.org/packages/bcrypt-1.1-2.fc9.src.rpm

APPROVED

It shows some warnings while building. -- They are all cosmetic and can be ignored.

But for small packages I will rather fixing them quickly;-)

May be you can try pushing this patch upstream, it removes all warnings I see.
http://rakesh.fedorapeople.org/misc/bcrypt.patch

 

New Package CVS Request
=======================
Package Name: bcrypt
Short Description: File encryption utility 
Owners: sundaram
Branches: F-8 F-9 EL-4 EL-5
InitialCC:
Cvsextras Commits: yes

cvs done.

bcrypt-1.1-2.fc9 has been submitted as an update for Fedora 9

bcrypt-1.1-2.fc8 has been submitted as an update for Fedora 8

bcrypt-1.1-2.fc9 has been pushed to the Fedora 9 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update bcrypt'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2008-7072

bcrypt-1.1-2.fc8 has been pushed to the Fedora 8 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update bcrypt'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F8/FEDORA-2008-7110

Same here -- I suppose you can push it to stable and close this ?

bcrypt-1.1-2.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.

bcrypt-1.1-2.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.