Bug 456312
| Summary: | Review Request: netbeans-javaparser - NetBeans Java Parser | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Victor G. Vasilyev <victor.vasilyev> |
| Component: | Package Review | Assignee: | Brian Pepple <bdpepple> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | bdpepple:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-08-29 12:09:57 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 456337 | ||
|
Description
Victor G. Vasilyev
2008-07-22 19:04:56 UTC
This is my first contribution so I need a sponsor please. MD5Sum:
668f3fa1d2189f58f02309d518f1aa14 nb-javaparser-6.1-src.zip
Good:
* Source URL is canonical
* Upstream source tarball verified
* Package name conforms to the Fedora Naming Guidelines
* Valid license tag
* Buildroot has all required elements
* All paths begin with macros
* Files have appropriate permissions and owners
* Package includes no pre-built jars
* jars files are located in %{_javadir}
* Package builds in koji/mock.
* Package installs and uninstalls cleanly
Bad:
* BR should include java-devel & jpackage-utils. Refer to
http://fedoraproject.org/wiki/Packaging/Java#BuildRequires_and_Requires
* Group Tag is not from the official list.
http://fedoraproject.org/wiki/RPMGroups
* rpmlint produces the following warnings:
netbeans-javaparser.noarch: W: no-documentation
netbeans-javaparser.noarch: W: non-standard-group Development/Java
2 packages and 0 specfiles checked; 0 errors, 2 warnings.
The next release is prepared for review. Spec URL: http://nbi.netbeans.org/files/documents/210/2052/netbeans-javaparser.spec SRPM URL: http://nbi.netbeans.org/files/documents/210/2107/netbeans-javaparser-6.1-2.fc10.src.rpm Changes: * BR should include java-devel & jpackage-utils. - java-devel & jpackage-utils are added as the build requirements - jpackage-utils is added as the run-time requirement * Group Tag is not from the official list. + netbeans-javaparser.noarch: W: non-standard-group Development/Java - An appropriate value of Group Tag is chosen from the official list * netbeans-javaparser.noarch: W: no-documentation - The package documentation is added rpmlint shows no errors and no warnings against both SRPM and RPM. Victory, sorry for the late approval on this, but I've been swamped at work. Anyway, the issues from comment #2 have been resolved. +1 APPROVED. New Package CVS Request ======================= Package Name: netbeans-javaparser Short Description: NetBeans Java Parser Owners: victorv Branches: InitialCC: cvs done. Successful koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=793056 |