Bug 456372
Summary: | assert FD_ISSET unnecessary in function slapd_clr_write | ||||||
---|---|---|---|---|---|---|---|
Product: | Red Hat Enterprise Linux 4 | Reporter: | Jatin Nansi <jnansi> | ||||
Component: | openldap | Assignee: | Jan Vcelak <jvcelak> | ||||
Status: | CLOSED CURRENTRELEASE | QA Contact: | |||||
Severity: | high | Docs Contact: | |||||
Priority: | urgent | ||||||
Version: | 4.6 | CC: | jplans, jwest, rvokal, sputhenp, tao, tsmetana | ||||
Target Milestone: | rc | Keywords: | ZStream | ||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2012-06-14 20:42:45 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 510233 | ||||||
Attachments: |
|
Description
Jatin Nansi
2008-07-23 07:48:55 UTC
Further looking at the code where slapd_daemon_task() calls connection_write(): the comment says that the stream may be inactive. In this case, we should not be asserting to check if it is active: -------------------------------------------------------- /* * NOTE: it is possible that the connection was closed * and that the stream is now inactive. * connection_write() must valid the stream is still * active. */ if ( connection_write( wd ) < 0 ) { FD_CLR( (unsigned) wd, &readfds ); slapd_close( wd ); } -------------------------------------------------------- upstream fix: http://www.openldap.org/devel/cvsweb.cgi/servers/slapd/daemon.c.diff?r1=1.418&r2=1.419&hideattic=1&sortbydate=0 It will need some backporting though. AFAIK there is no reproducer, right? Openldap in RHEL5 suffers from the same bug, which will get fixed with rebase to openldap-2.3.43 (bug #454994). Jan, You are correct, there is no reproducer. Created attachment 315458 [details]
backported patch
This request was evaluated by Red Hat Product Management for inclusion, but this component is not scheduled to be updated in the current Red Hat Enterprise Linux release. If you would like this request to be reviewed for the next minor release, ask your support representative to set the next rhel-x.y flag to "?". |