Bug 456517

Summary:	Review Request: fotoxx - Photo editor
Product:	[Fedora] Fedora	Reporter:	Nicoleau Fabien <nicoleau.fabien>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting, pahan
Target Milestone:	---	Flags:	panemade: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	4.9-1.fc9	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-08-01 01:47:35 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Nicoleau Fabien 2008-07-24 11:13:25 UTC

Spec URL: http://nicoleau.fabien.free.fr/rpms/SPECS/fotoxx.spec
SRPM URL: http://nicoleau.fabien.free.fr/rpms/srpms.fc9/fotoxx-4.9-1.fc9.src.rpm
Description:
Fotoxx is a free open source Linux program for editing image files
from a digital camera. The goal of fotoxx is to meet most image editing
needs while remaining easy to use.

rpmlint output : 
[builder@FEDOBOX tmp]$ rpmlint fotoxx-4.9-1.fc9.i386.rpm fotoxx-debuginfo-4.9-1.fc9.i386.rpm fotoxx-4.9-1.fc9.src.rpm 
3 packages and 0 specfiles checked; 0 errors, 0 warnings.
[builder@FEDOBOX tmp]$ 

package builds on koji :
http://koji.fedoraproject.org/koji/taskinfo?taskID=735847

Comment 1 Adel Gadllah 2008-07-24 11:49:28 UTC

*** Bug 442244 has been marked as a duplicate of this bug. ***

Comment 2 Parag AN(पराग) 2008-07-24 11:58:03 UTC

Review:
+ package builds in mock (rawhide i386).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=735923
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
bbc9b2522331960f1bf5cab9b7b09ca0  fotoxx-4.9.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Desktop file installed correctly.

* Remove unnecessary BR:pkgconfig

APPROVED.

Comment 3 Nicoleau Fabien 2008-07-24 12:45:23 UTC

New Package CVS Request
=======================
Package Name: fotoxx
Short Description: Photo editor
Owners: eponyme
Branches: F-8 F-9
InitialCC: 
Cvsextras Commits: yes

Comment 4 Kevin Fenzi 2008-07-24 18:28:58 UTC

cvs done.

Comment 5 Fedora Update System 2008-07-24 19:36:28 UTC

fotoxx-4.9-1.fc8 has been submitted as an update for Fedora 8

Comment 6 Fedora Update System 2008-07-24 19:38:54 UTC

fotoxx-4.9-1.fc9 has been submitted as an update for Fedora 9

Comment 7 Fedora Update System 2008-08-01 01:47:32 UTC

fotoxx-4.9-1.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2008-08-01 01:47:44 UTC

fotoxx-4.9-1.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.