Bug 456919
Summary: | when a sound is selected with the file chooser in g-s-p, make sure to default to /usr/share/sounds if that dir exists | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Lennart Poettering <lpoetter> | ||||
Component: | control-center | Assignee: | Bastien Nocera <bnocera> | ||||
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | low | Docs Contact: | |||||
Priority: | low | ||||||
Version: | rawhide | CC: | mclasen, rstrode | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2008-10-10 09:20:45 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 465130 | ||||||
Attachments: |
|
Description
Lennart Poettering
2008-07-28 16:37:43 UTC
When you manage to say all that in the subject, it means it's too long. But the problem is that we use XDG_DATA_DIRS. Which one of the directories should we select? Or should we force using $(datadir)/sounds? Since you add only /usr/share/sounds to the shortcuts list, not all $XDG_DATA_DIRS/sound, it would seem logical to open the file chooser in that directory too. The first part of XDG_DATA_DIRS perhaps? I guess it would even be OK to hard code that to $(datadir)/sounds since if XDG_DATA_DIRS is not set (wich it usually is not) it would default to that dir anyway (plus /usr/share/local) The default for g_get_system_data_dirs() is: - when XDG_DATA_DIRS isn't set: -> /usr/local/share/:/usr/share/ - when set, well, all bets are off. I'd hard-code it to $(datadir)/sounds myself... Yeah /usr/share/sounds is the only sane default. Since that is the only place where a newly installed system will have sounds... Created attachment 319874 [details]
Set a default directory
We use whatever we managed to insert first as a shortcut folder for the default directory. Not tested.
Fixed in 2.24.0.1-6 |