Bug 457013

Summary:	pppoe: Check packet length on all receive paths [rhel-5.3]
Product:	Red Hat Enterprise Linux 5	Reporter:	Eugene Teo (Security Response) <eteo>
Component:	kernel	Assignee:	Jiri Pirko <jpirko>
Status:	CLOSED ERRATA	QA Contact:	Martin Jenner <mjenner>
Severity:	low	Docs Contact:
Priority:	low
Version:	5.3	CC:	dzickus, herbert.xu, lwang, nhorman, riek, rkhan, tgraf
Target Milestone:	rc
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-01-20 20:24:25 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	457014, 457015

Description Eugene Teo (Security Response) 2008-07-29 08:18:41 UTC

Description of problem:
The length field in the PPPOE header wasn't checked completely. It lacks of a
lower-bound check. Also, call skb_copy_datagram_iovec instead of memcpy_toiovec
so that paged packets (rare for PPPOE) are handled properly.

Comment 1 Eugene Teo (Security Response) 2008-07-29 08:19:37 UTC

Proposed upstream patch:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=392fdb0e35055b96faa9c1cd6ab537805337cdce

Comment 2 Jiri Pirko 2008-08-27 08:07:37 UTC

patch sent: http://post-office.corp.redhat.com/archives/rhkernel-list/2008-August/msg01354.html

Comment 3 Don Zickus 2008-09-11 19:43:41 UTC

in kernel-2.6.18-111.el5
You can download this test kernel from http://people.redhat.com/dzickus/el5

Comment 7 errata-xmlrpc 2009-01-20 20:24:25 UTC

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2009-0225.html