Bug 457014

Summary:	pppoe: Check packet length on all receive paths [mrg-1]
Product:	Red Hat Enterprise MRG	Reporter:	Eugene Teo (Security Response) <eteo>
Component:	realtime-kernel	Assignee:	Luis Claudio R. Goncalves <lgoncalv>
Status:	CLOSED ERRATA	QA Contact:
Severity:	low	Docs Contact:
Priority:	low
Version:	1.1	CC:	bhu, davids, eteo, lgoncalv, lwang, williams
Target Milestone:	1.0.3
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-10-07 19:21:26 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	457013
Bug Blocks:

Description Eugene Teo (Security Response) 2008-07-29 08:20:45 UTC

+++ This bug was initially created as a clone of Bug #457013 +++

Description of problem:
The length field in the PPPOE header wasn't checked completely. It lacks of a
lower-bound check. Also, call skb_copy_datagram_iovec instead of memcpy_toiovec
so that paged packets (rare for PPPOE) are handled properly.

Comment 1 Eugene Teo (Security Response) 2008-07-29 08:20:58 UTC

Proposed upstream patch:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=392fdb0e35055b96faa9c1cd6ab537805337cdce

Comment 2 Luis Claudio R. Goncalves 2008-08-05 18:16:36 UTC

Patch enqueued for -76, applied as is.

Comment 4 David Sommerseth 2008-09-23 08:25:58 UTC

Verified that upstream patch 392fdb0e35055b96faa9c1cd6ab537805337cdce is included in mrt-rt-2.6.24.7-81.

Comment 6 errata-xmlrpc 2008-10-07 19:21:26 UTC

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2008-0857.html