Bug 457015

Summary:	pppoe: Check packet length on all receive paths [rhel-4.8]
Product:	Red Hat Enterprise Linux 4	Reporter:	Eugene Teo (Security Response) <eteo>
Component:	kernel	Assignee:	Jiri Pirko <jpirko>
Status:	CLOSED ERRATA	QA Contact:	Martin Jenner <mjenner>
Severity:	low	Docs Contact:
Priority:	low
Version:	4.8	CC:	eteo, herbert.xu, lwang, nhorman, rkhan, tgraf, vgoyal
Target Milestone:	rc
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-05-18 19:36:54 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	457013
Bug Blocks:

Description Eugene Teo (Security Response) 2008-07-29 08:25:17 UTC

+++ This bug was initially created as a clone of Bug #457013 +++

Description of problem:
The length field in the PPPOE header wasn't checked completely. It lacks of a
lower-bound check. Also, call skb_copy_datagram_iovec instead of memcpy_toiovec
so that paged packets (rare for PPPOE) are handled properly.

Comment 1 Eugene Teo (Security Response) 2008-07-29 08:25:50 UTC

Proposed upstream patch:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=392fdb0e35055b96faa9c1cd6ab537805337cdce

Comment 2 Jiri Pirko 2008-08-27 08:06:49 UTC

patch sent: http://post-office.corp.redhat.com/archives/rhkernel-list/2008-August/msg01355.html

Comment 3 RHEL Program Management 2008-09-22 14:52:06 UTC

This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 4 Vivek Goyal 2008-09-30 21:16:11 UTC

Committed in 78.12.EL . RPMS are available at http://people.redhat.com/vgoyal/rhel4/

Comment 7 errata-xmlrpc 2009-05-18 19:36:54 UTC

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2009-1024.html