Bug 457030

Summary:	Review Request: rubygem-attributes - Attributes for Ruby (GEM)
Product:	[Fedora] Fedora	Reporter:	Jeroen van Meeuwen <vanmeeuwen+fedora>
Component:	Package Review	Assignee:	S.A. Hartsuiker <s.a.hartsuiker>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, mhicks, notting
Target Milestone:	---	Flags:	s.a.hartsuiker: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-08-24 14:10:56 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jeroen van Meeuwen 2008-07-29 10:20:01 UTC

Spec URL: http://www.kanarip.com/custom/SPECS/rubygem-attributes.spec
SRPM URL: http://www.kanarip.com/custom/f10/SRPMS/rubygem-attributes-5.0.1-2.fc10.src.rpm
Description: Attributes for Ruby (GEM)

Comment 1 S.A. Hartsuiker 2008-07-29 20:10:48 UTC

review in progress

Comment 2 S.A. Hartsuiker 2008-07-29 20:18:44 UTC

RPM Lint: a no %doc warning
Package name: ok
Spec file: ok
License: GPLv2,Ruby
Actual License: GPLv2+,Ruby
%doc License: n/a
Spec file language: ok
Spec file readable: ok
Upstream source vs. used tarball: ok
Compile and Build:
 - F-7: builds
 - F-8: builds
 - rawhide: builds
 - EL-5: builds

Applicable Package Guidelines: 
 
Locales: not applicable
Shared libs: not applicable

Relocatable: no
Directory and file ownership: ok
No duplicate files in %files: ok
File Permissions: ok
Macro usage: ok
Code vs. Content: ok
(Large) Documentation: ok
%doc affecting runtime: no
Header files in -devel package: not applicable
Static Libraries in -static package: not applicable
pkgconfig Requires: not applicable
Library files: not applicable
Devel requires base package: not applicable
.la libtool archives: not applicable
Duplicate ownership of files/directories: no
Remove BuildRoot: yes
UTF-8 filenames: no 

There is a README in the rpm, it should be marked as %doc
Otherwise no problems.

Comment 3 Jeroen van Meeuwen 2008-07-31 09:56:34 UTC

OK:

SPEC: http://www.kanarip.com/custom/SPECS/rubygem-attributes.spec
SRPM:
http://www.kanarip.com/custom/f10/SRPMS/rubygem-attributes-5.0.1-3.fc10.src.rpm

Comment 4 S.A. Hartsuiker 2008-07-31 11:26:47 UTC

Ok
%doc is fixed now.
package approved

Comment 5 Jeroen van Meeuwen 2008-08-02 09:38:23 UTC

New Package CVS Request
=======================
Package Name: rubygem-attributes
Short Description: Attributes for Ruby (Gem)
Owners: kanarip
Branches: EL-5, F-8, F-9, devel
InitialCC: kanarip
Cvsextras Commits: yes

Comment 6 Kevin Fenzi 2008-08-05 16:37:58 UTC

cvs done.

Comment 7 Fedora Update System 2008-08-23 12:57:38 UTC

rubygem-attributes-5.0.1-3.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/rubygem-attributes-5.0.1-3.fc9

Comment 8 Fedora Update System 2008-08-23 12:57:41 UTC

rubygem-attributes-5.0.1-3.fc8 has been submitted as an update for Fedora 8.
http://admin.fedoraproject.org/updates/rubygem-attributes-5.0.1-3.fc8

Comment 9 Fedora Update System 2008-09-10 07:12:44 UTC

rubygem-attributes-5.0.1-3.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2008-09-10 07:13:12 UTC

rubygem-attributes-5.0.1-3.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.