Bug 457037

Summary: Anaconda should not allow /boot as a ext4dev partition
Product: [Fedora] Fedora Reporter: James Laska <jlaska>
Component: anacondaAssignee: Chris Lumens <clumens>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: esandeen, jturner
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-07-29 15:03:41 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
anaconda-i386-logs.tgz
none
anaconda-ppc-logs.tgz
none
457037.patch
none
Expected error dialog when using applied patch none

Description James Laska 2008-07-29 11:36:19 UTC 
F9 anaconda allows creation of /boot as an ext4dev partition.

According to esandeen, grub does not yet support ext4 format.  Perhaps anaconda
should not allow leaving the partitioning screen while /boot exists on ext4.

I have tested this in both i386 and ppc rawhide (see attached logs).
Comment 1 James Laska 2008-07-29 11:36:19 UTC 
Created attachment 312858 [details]
anaconda-i386-logs.tgz
Comment 2 James Laska 2008-07-29 11:36:44 UTC 
Created attachment 312859 [details]
anaconda-ppc-logs.tgz
Comment 3 James Laska 2008-07-29 12:31:08 UTC 
Could it be a typo in partitions.py ?

diff --git a/partitions.py b/partitions.py
index 785a85d..2b0bc37 100644
--- a/partitions.py
+++ b/partitions.py
@@ -1249,7 +1249,7 @@ class Partitions:
                 # XFS causes problems as /boot. see #138673 and others
                 # gfs2 and ext4 aren't supported by grub
                 if (bootreq.fstype and
-                    bootreq.fstype.getName() in ("xfs", "gfs2", "ext4")):
+                    bootreq.fstype.getName() in ("xfs", "gfs2", "ext4dev")):
                     errors.append(_("Bootable partitions cannot be on an %s "
                                     "filesystem.")%(bootreq.fstype.getName(),))
 

Tested the above patch on rawhide ppc ... it seems to do the trick and not allow
the user to proceed past partitioning with /boot as an 'ext4dev' device.
Comment 4 James Laska 2008-07-29 12:31:55 UTC 
Created attachment 312862 [details]
457037.patch
Comment 5 James Laska 2008-07-29 12:32:25 UTC 
Created attachment 312863 [details]
Expected error dialog when using applied patch
Comment 6 Eric Sandeen 2008-07-29 13:17:12 UTC 
ext4 & ext4dev should probably both be in the list.

-Eric
Comment 7 Chris Lumens 2008-07-29 15:03:41 UTC 
Thanks for tracking this down.  I went about fixing it a different way - by
giving the filesystem type objects the ability to say whether or not they can
host /boot.