Bug 457186
| Summary: | Update to grip 3.3.1 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Stefan Becker <chemobejk> | ||||
| Component: | grip | Assignee: | Adrian Reber <adrian> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | low | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 9 | Keywords: | FutureFeature | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | http://sourceforge.net/project/showfiles.php?group_id=3714&package_id=3673&release_id=337633 | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Enhancement | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2008-09-25 00:12:45 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Stefan Becker
2008-07-30 05:49:20 UTC
The problem with grip 3.3.1 is that it is marked as a development version and it (used to) has that annoying warning box when started that it should not be used because it is a development version. So I will not update it to 3.3.1. OK, I didn't know that. Can you at least consider to backport that "execute command after encode has been completed" patch? That would be a very useful addition ontop of 3.2.0. I will look at applying the patch you mentioned. Patch seems to apply. Can you do some tests if it works like it should if I submit it to Fedora 9 updates-testing? Sure, go ahead. grip-3.2.0-21.fc9 has been submitted as an update for Fedora 9 Tested with external command: /usr/bin/vorbisgain external command options: -a -f -n -s /home/stefanb/ogg/%!A/%!d (the !'s are necessary to force file name munging) While it seems to work OK the patch is bogus: - "execute after encode" works exactly like "encode filter command", which is *NOT* what is desired - the implementation is broken as no waitpid() is called to reap dead child processes, i.e. for each encoded track there will be a zombie process :-( I'll look into the patch to see what can be done... Created attachment 313917 [details]
Corrected "execute command after encode" patch
- command is now executed after last encode finnishes
- use the correct launch function to ensure proper cleanup of child processes
Tested with:
Execute after encode command: /usr/bin/vorbisgain -a -f -n -s /home/stefanb/ogg/%!A/%!d
grip-3.2.0-21.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update grip'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2008-7224 grip-3.2.0-22.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/grip-3.2.0-22.fc9 grip-3.2.0-22.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update grip'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2008-7703 grip-3.2.0-22.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. |