Bug 457544
| Summary: | Review Request: perl-IPTables-ChainMgr - A Perl extension for manipulating iptables policies | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Miloslav Trmač <mitr> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | admiller, fedora-package-review, notting, panemade, pvrabec |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-08-14 11:35:33 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 457543 | ||
| Bug Blocks: | 457888 | ||
|
Description
Miloslav Trmač
2008-08-01 13:03:28 UTC
Review: + package builds in mock (rawhide i386). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=766523 + rpmlint is silent for SRPM and for RPM. + source files match upstream url c1851a9ca74d47e6edb66e363474e313 IPTables-ChainMgr-0.7.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=1, Tests=1, 0 wallclock secs ( 0.01 usr 0.00 sys + 0.03 cusr 0.00 csys = 0.04 CPU) + Package perl-IPTables-ChainMgr-0.7-1.fc10 => Provides: perl(IPTables::ChainMgr) = 0.5 Requires: perl >= 0:5.006 perl(Carp) perl(IPTables::Parse) perl(Net::IPv4Addr) perl(POSIX) perl(strict) perl(vars) perl(warnings) APPROVED. New Package CVS Request ======================= Package Name: perl-IPTables-ChainMgr Short Description: Perl extension for manipulating iptables policies Owners: mitr Branches: F-9 InitialCC: perl-sig Cvsextras Commits: yes cvs done. you can build package as cvs is done. done. (mitr is on vacation) Package Change Request ====================== Package Name: perl-IPTables-ChainMgr New Branches: el6 Owners: maxamillion Any comments from the Fedora maintainers? (In reply to Adam Miller from comment #6) > Package Change Request > ====================== > Package Name: perl-IPTables-ChainMgr > New Branches: el6 > Owners: maxamillion (In reply to Jon Ciesla from comment #7) > Any comments from the Fedora maintainers? ACK to this request. Git done (by process-git-requests). Package Change Request ====================== Package Name: perl-IPTables-ChainMgr New Branches: epel7 Owners: maxamillion Git done (by process-git-requests). |