Bug 457767

Summary:	Review Request: xorg-x11-drv-mach64 - mach64 driver
Product:	[Fedora] Fedora	Reporter:	Adam Jackson <ajax>
Component:	Package Review	Assignee:	Rakesh Pandit <rpandit>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting, rpandit
Target Milestone:	---	Flags:	rpandit: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-08-11 03:15:12 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Adam Jackson 2008-08-04 15:04:37 UTC

Spec URL: http://ajax.fedorapeople.org/mach64/xorg-x11-drv-mach64.spec
SRPM URL: http://ajax.fedorapeople.org/mach64/xorg-x11-drv-mach64.src.rpm

X driver for mach64 devices.  Split out from the -ati driver package upstream, so splitting it out here as well.

spec file is more or less cloned from -ati's spec.

Comment 1 Adam Jackson 2008-08-06 15:40:08 UTC

Sorry, wrong SRPM URL.

SRPM URL: http://ajax.fedorapeople.org/mach64/xorg-x11-drv-mach64-6.8.0-1.fc9..src.rpm

Comment 2 Rakesh Pandit 2008-08-06 15:43:55 UTC

Removed Extra dot ;-)
http://ajax.fedorapeople.org/mach64/xorg-x11-drv-mach64-6.8.0-1.fc9.src.rpm

Comment 3 Rakesh Pandit 2008-08-06 17:35:03 UTC

APPROVED

Build on koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=762691

rpmlint -i xorg-x11-drv-mach64-6.8.0-1.fc9.src.rpm 
xorg-x11-drv-mach64.src: W: mixed-use-of-spaces-and-tabs (spaces: line 5, tab: line 3)
The specfile mixes use of spaces and tabs for indentation, which is a cosmetic
annoyance.  Use either spaces or tabs for indentation, not both.

Required:
[x] Name
[x] License
[x] Spec file is in American Eng and legible
[x] Build successfully
[x] BuildRequires 
[x] Duplicate files - nil
[NA] locale
[x] permissions -- okay
[x]  source link correct
[x] packaging guidlines
[x] removing .la 
[x] Buildroot correct
[x] owns every directory it creates
[x] file encoding - checked
[x] package has no dependency on files in %doc
[NA] GUI
[x] No dependencies outside FHS guidelines
[x] md5sum
Source from site: 6081b8fa50c689d51f85c2fbaf93867e
Source from srpm: 6081b8fa50c689d51f85c2fbaf93867e

Optional suggestions:
a. You may like to add some more info to description 
b. clean #{_mandir}/man4/mach64.4*
c. BuildRequires: automake autoconf libtool pkgconfig may be removed

Key NA = N/A, x = Check, ! = Problem, ? = Not evaluated

Comment 4 Adam Jackson 2008-08-06 21:21:54 UTC

New Package CVS Request
=======================
Package Name: xorg-x11-drv-mach64
Short Description: X.org X11 mach64 driver
Owners: xgl-maint
Branches:
InitialCC:
Cvsextras Commits: yes

Comment 5 Kevin Fenzi 2008-08-07 21:00:20 UTC

cvs done.

Comment 6 Adam Jackson 2008-08-11 03:15:12 UTC

Imported and built in rawhide, closing.