Bug 457770

Created attachment 314236 [details]
Patch to add system.multicall functionality to compat_xmlrpc layer (v1)

Thanks for the report. It was indeed left out unintentionally during the porting of RH customizations to the new version of Bugzilla.

Attached is a patch to add system.multicall as well as a simple system.ping to the compat_xmlrpc layer. I have tested this to work on bz-web2-test. Please take a look.

Dave

Is bz-web2-test externally visible, or is there any way for us outside of Red Hat to test our scripts against these patches without bringing up our own bugzilla instances?

The output format seems to have changed in an unusual way.  The output used to be a list of hashes, each hash corresponding to the results of an individual call in the multicall.  Now, for each call, I get two hashes in the output list.  The first contains some metadata about the call that was made, like this:

{'full_method': 'bugzilla::getBug',
  'method': 'getBug',
  'package': 'bugzilla',
  'params': [303591, '<username>@redhat.com', '<password>'],
  'userid': 0},

followed by another hash that contains the results of the call.  So if I do a multicall encapsulating 2 calls, I'll get a output list with 4 entries in it.  Is this the expected behavior?

(In reply to comment #2)
> Is bz-web2-test externally visible, or is there any way for us outside of Red
> Hat to test our scripts against these patches without bringing up our own
> bugzilla instances?

bz-web2-test is internal development instance only. For large features we need more feedback/testing from the broader community, then we push updates packages to partner-bugzilla.redhat.com which is our external staging server. This fix will be tested by a couple internally on our development box and will go out asap so there is probably no need to push an update to partner-bugzilla.

Thanks
Dave

(In reply to comment #3)
> The output format seems to have changed in an unusual way.  The output used to
> be a list of hashes, each hash corresponding to the results of an individual
> call in the multicall.  Now, for each call, I get two hashes in the output
> list.  The first contains some metadata about the call that was made, like
> this:
> 
> {'full_method': 'bugzilla::getBug',
>   'method': 'getBug',
>   'package': 'bugzilla',
>   'params': [303591, '<username>@redhat.com', '<password>'],
>   'userid': 0},
> 
> followed by another hash that contains the results of the call.  So if I do a
> multicall encapsulating 2 calls, I'll get a output list with 4 entries in it. 
> Is this the expected behavior?

That is my fault. I had some debugging info enabled which is the reason for the extra data. I have turned off the additional info and you should get the same results as before now.

Dave

My test script, tested against bz-web2-test, works now.

Comment on attachment 314236 [details]
Patch to add system.multicall functionality to compat_xmlrpc layer (v1)

Hey Dave, looks good to me. 
Tested it locally and on bz-web2 and seems to work fine.

Thanks,
Noura

Thanks Noura. Checked into CVS now. Should be in the next update (today).

Dave