Bug 457796
Summary: | PATCH(es): fixes + libv4l support + more fixes | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Hans de Goede <hdegoede> | ||||||||||
Component: | xawtv | Assignee: | Dmitry Butskoy <dmitry> | ||||||||||
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||||
Severity: | medium | Docs Contact: | |||||||||||
Priority: | medium | ||||||||||||
Version: | rawhide | ||||||||||||
Target Milestone: | --- | ||||||||||||
Target Release: | --- | ||||||||||||
Hardware: | All | ||||||||||||
OS: | Linux | ||||||||||||
Whiteboard: | |||||||||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||||||||
Doc Text: | Story Points: | --- | |||||||||||
Clone Of: | Environment: | ||||||||||||
Last Closed: | 2008-08-26 16:58:20 UTC | Type: | --- | ||||||||||
Regression: | --- | Mount Type: | --- | ||||||||||
Documentation: | --- | CRM: | |||||||||||
Verified Versions: | Category: | --- | |||||||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||||||
Embargoed: | |||||||||||||
Attachments: |
|
Description
Hans de Goede
2008-08-04 17:32:35 UTC
Created attachment 313381 [details]
xawtv-3.95-libv4l2.patch
Created attachment 313382 [details]
xawtv-3.95-no-dga.patch
Created attachment 313392 [details]
xawtv-3.95-v4l-conf-user-bpl.patch
Ping, I would really like to see this fixed before F10-beta freeze so that the better webcam support feature can get some good testing in the Beta. Pong. I am still thinking how to make libv4l2 support optional... It seems that an option is not suitable here, as there are several applications (xawtv, streamer, fbtv, ...) and it is not good to hack all their cmdline interfaces. Perhaps LD_PRELOAD is a way? If the only application still used by "end users" is "xawtv", then maybe just add "LD_PRRELOAD=..." into its .desktop file? (Saving all another utils unchanged). P.S. Could you add autoconf stuff for libv4l2 patch as well? (In reply to comment #5) > Pong. > > I am still thinking how to make libv4l2 support optional... > Why would you want todo that? libv4l was explicitly designed to be transparent to the application. With the current patch, libv4l does not get used / linked in to the lowlevel v4l-info, v4l-conf and v4lctl programs, so those are not affected, all the others actually stream data from the cam in one form or the other and thus need libv4l to work with cams which have funky video formats (IOW most of them!!). > P.S. Could you add autoconf stuff for libv4l2 patch as well? Why? Its a distro specific patch and we will always want to enable libv4l support, I will take a look at autoconf support when a new upstream is formed and patches need to become non distro specific so that they can be merged upstream. > libv4l does not get used / linked in to the lowlevel
> v4l-info, v4l-conf and v4lctl programs
"v4lctl" actually uses libng drivers, ie. the patch affects it as well.
(In reply to comment #7) > > libv4l does not get used / linked in to the lowlevel > > v4l-info, v4l-conf and v4lctl programs > > "v4lctl" actually uses libng drivers, ie. the patch affects it as well. Ah I didn't know that even then though, this is not a problem as libv4l does not touch any of the CTRL related ioctl's it passes them through to the kernel *completely* unmodified. OK I've added your patches (I have a little touched them, and add manual stuff for the "-p pitch"). Additionally, I've added some debian ones. The results are available in Koji: http://kojipkgs.fedoraproject.org/packages/xawtv/3.95/10.fc10/ Looks (In reply to comment #9) > OK > > I've added your patches (I have a little touched them, and add manual stuff for > the "-p pitch"). Additionally, I've added some debian ones. > > The results are available in Koji: > http://kojipkgs.fedoraproject.org/packages/xawtv/3.95/10.fc10/ Works like a charm, including accessing webcams which do not work without libv4l and using my bttv tv card. Thanks! |