Bug 457889

Summary:	RFE: gallery2: consider switching to using system Smarty if possible
Product:	[Fedora] Fedora	Reporter:	Tomas Hoger <thoger>
Component:	gallery2	Assignee:	John Berninger <john>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	gwync
Target Milestone:	---	Keywords:	Reopened
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	2.2.4-3	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-12-18 20:38:30 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Tomas Hoger 2008-08-05 08:46:55 UTC

Description of problem:
Current gallery2 packages contain a private copy of Smarty, which is also
packaged in Fedora as php-Smarty.  Any bug (or security issue) in Smarty now
requires update of both php-Smarty and all applications having own copy.

Please investigate if gallery2 can be used with system Smarty, or depends on some project-specific customizations.

Possible straight forward way to use system smarty is to do something like:
  rm -rf /usr/share/gallery2/lib/smarty
  ln -s /usr/share/php/Smarty/ /usr/share/gallery2/lib/smarty

+ depends on php-Smarty (this should already be done).

Ideally, there may be a way to use system smarty without exposing it in the
directory served by web server, as was done in php-pear-PhpDocumentor:
http://cvs.fedoraproject.org/viewcvs/rpms/php-pear-PhpDocumentor/devel/php-pear-PhpDocumentor.spec?r1=1.4&r2=1.5


Version-Release number of selected component (if applicable):
gallery2-2.2.5-1.fc9


Additional info:
The attempt was already made to do this change:
http://cvs.fedoraproject.org/viewcvs/rpms/gallery2/devel/gallery2.spec?r1=1.14&r2=1.15
However, it spec file tries to remove Smarty directory, instead of smarty, and local copy is still shipped (php-Smarty dependency seems redundant).

Other libraries with local copies in lib/ may also have system package
counterpart.

Comment 1 John Berninger 2008-08-05 11:32:48 UTC

This was done in version 2.2.4-3 (three releases ago), per the RPM changelog of the package.

Comment 2 Tomas Hoger 2008-08-05 12:43:51 UTC

(In reply to comment #1)
> This was done in version 2.2.4-3 (three releases ago), per the RPM changelog of
> the package.

John, you did not read the bug description very carefully, right?  Quoting myself:

Additional info:
The attempt was already made to do this change:
http://cvs.fedoraproject.org/viewcvs/rpms/gallery2/devel/gallery2.spec?r1=1.14&r2=1.15
However, it spec file tries to remove Smarty directory, instead of smarty, and
local copy is still shipped (php-Smarty dependency seems redundant).

That's the change done in 2.2.4-3 and I described why it did not solve the issue.

Comment 3 Gwyn Ciesla 2008-12-18 18:45:44 UTC

Working on a correction.

Comment 4 Gwyn Ciesla 2008-12-18 20:38:30 UTC

Fixed in rawhide.