Bug 458019

Summary:	kernel: random32: seeding improvement [rhel-5.3]
Product:	Red Hat Enterprise Linux 5	Reporter:	Eugene Teo (Security Response) <eteo>
Component:	kernel	Assignee:	Jiri Pirko <jpirko>
Status:	CLOSED ERRATA	QA Contact:	Martin Jenner <mjenner>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	5.3	CC:	dzickus, herbert.xu, lwang, pzijlstr, rkhan, rlerch, security-response-team
Target Milestone:	rc
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	random32() seeding has been improved.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-01-20 20:15:03 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	458016
Bug Blocks:	458021

Description Eugene Teo (Security Response) 2008-08-06 06:29:36 UTC

+++ This bug was initially created as a clone of Bug #458016 +++

Description of problem:
Stephen Hemminger wrote a patch to improve random32() seeding.

The rationale is:
   * use u32 consistently
   * no need to do LCG on values from (better) get_random_bytes
   * use more data from get_random_bytes for secondary seeding
   * don't reduce state space on srandom32()
   * enforce state variable initialization restrictions

--- Additional comment from eteo on 2008-08-06 02:18:35 EDT ---

Proposed upstream patch:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=697f8d0348a652593d195a13dd1067d9df911a82

--- Additional comment from eteo on 2008-08-06 02:22:51 EDT ---

Created an attachment (id=313529)
Upstream patch for this issue

Comment 1 Jiri Pirko 2008-08-26 16:30:16 UTC

also adding following upstream patch:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=61407f80f72970d52d4339f81c6c3cd03f4ca0f0

Comment 2 Jiri Pirko 2008-08-29 07:22:32 UTC

patch sent: http://post-office.corp.redhat.com/archives/rhkernel-list/2008-August/msg01507.html

Comment 3 RHEL Program Management 2008-09-04 16:55:00 UTC

This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 4 Don Zickus 2008-09-10 20:14:37 UTC

in kernel-2.6.18-110.el5
You can download this test kernel from http://people.redhat.com/dzickus/el5

Comment 7 Ryan Lerch 2008-11-06 06:37:28 UTC

This bug (feature request) has been marked for inclusion in the Red Hat
Enterprise Linux 5.3 Release Notes.

To aid in the development of relevant and accurate release notes, please fill
out the "Release Notes" field above with the following 4 pieces of information:


Cause:   What actions or circumstances induced the feature request.

Consequence:  What action was inhibited by the feature's absence.

Fix:   What was done to implement the feature.

Result:  now happens when the actions or circumstances above occur. (NB: this
is not the same as 'the feature request was fulfilled')

Comment 8 Jiri Pirko 2008-11-06 07:03:54 UTC

Release note added. If any revisions are required, please set the 
"requires_release_notes" flag to "?" and edit the "Release Notes" field accordingly.
All revisions will be proofread by the Engineering Content Services team.

New Contents:
random32() seeding has been improved.

Comment 14 errata-xmlrpc 2009-01-20 20:15:03 UTC

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2009-0225.html