Bug 458023

Summary:	kernel: random32: seeding improvement [rhel-4.7.z]
Product:	Red Hat Enterprise Linux 4	Reporter:	Eugene Teo (Security Response) <eteo>
Component:	kernel	Assignee:	Vitaly Mayatskikh <vmayatsk>
Status:	CLOSED WONTFIX	QA Contact:	Martin Jenner <mjenner>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	4.7.z	CC:	dhoward, lwang, security-response-team, syeghiay, vmayatsk
Target Milestone:	rc	Keywords:	ZStream
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-05-15 15:10:59 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	458016, 458022
Bug Blocks:

Description Eugene Teo (Security Response) 2008-08-06 06:44:26 UTC

+++ This bug was initially created as a clone of Bug #458016 +++

Description of problem:
Stephen Hemminger wrote a patch to improve random32() seeding.

The rationale is:
   * use u32 consistently
   * no need to do LCG on values from (better) get_random_bytes
   * use more data from get_random_bytes for secondary seeding
   * don't reduce state space on srandom32()
   * enforce state variable initialization restrictions

--- Additional comment from eteo on 2008-08-06 02:18:35 EDT ---

Proposed upstream patch:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=697f8d0348a652593d195a13dd1067d9df911a82

--- Additional comment from eteo on 2008-08-06 02:22:51 EDT ---

Created an attachment (id=313529)
Upstream patch for this issue

Comment 2 RHEL Program Management 2008-08-07 14:43:52 UTC

This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 4 Eugene Teo (Security Response) 2008-08-26 16:54:52 UTC

It needs the following upstream patch as well:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=61407f80f72970d52d4339f81c6c3cd03f4ca0f0